From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWqUS-0000tj-3H for qemu-devel@nongnu.org; Tue, 01 Sep 2015 14:41:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWqUO-0000lQ-1j for qemu-devel@nongnu.org; Tue, 01 Sep 2015 14:41:03 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:48128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWqUN-0000iQ-9Q for qemu-devel@nongnu.org; Tue, 01 Sep 2015 14:40:59 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Sep 2015 12:40:58 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 1B30519D803E for ; Tue, 1 Sep 2015 12:31:51 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t81Ic16N14024898 for ; Tue, 1 Sep 2015 11:38:01 -0700 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t81IetKB002647 for ; Tue, 1 Sep 2015 12:40:55 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1438703896-12553-31-git-send-email-armbru@redhat.com> References: <1438703896-12553-1-git-send-email-armbru@redhat.com> <1438703896-12553-31-git-send-email-armbru@redhat.com> Message-ID: <20150901184026.18566.39890@loki> Date: Tue, 01 Sep 2015 13:40:26 -0500 Subject: Re: [Qemu-devel] [PATCH RFC v3 30/32] qapi: New QMP command query-schema for QMP schema introspection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com Quoting Markus Armbruster (2015-08-04 10:58:14) > Caution, rough edges. > = > qapi/introspect.json defines the introspection schema. It should do > for uses other than QMP. > FIXME it's almost entirely devoid of comments. > = > The introspection schema does not reflect all the rules and > restrictions that apply to QAPI schemata. A valid QAPI schema has an > introspection value conforming to the introspection schema, but the > converse is not true. > = > Introspection lowers away a number of schema details: > = > * The built-in types are declared with their JSON type. > = > TODO Should we map all the integer types to just int? I don't think we should. If management chooses to handle them in this generic fashion that's their perogative/problem, but treating all ints as a single generic type can lead to unexpected results when those values get passed on to functions expecting, for instance, uint8_t. So QEMU should do its part to convey this information somehow.