From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX2U0-00006t-P6 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 03:29:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX2Tw-0004r0-O9 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 03:29:24 -0400 Date: Wed, 2 Sep 2015 16:24:07 +1000 From: David Gibson Message-ID: <20150902062407.GA30411@voom.redhat.com> References: <1437522016-23226-1-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: <1437522016-23226-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH for-2.4] spapr_drc: fix clang -fsanitizer=shift warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: peter.maydell@linaro.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 21, 2015 at 06:40:16PM -0500, Michael Roth wrote: > Current code for generating DRC type mask generates the following warning= with > clang -fsanitizer=3Dundefined -fsanitizer=3Dshift: >=20 > runtime error: left shift of negative value -1 >=20 > Fix this by calculating the mask like a sane person would. >=20 > Signed-off-by: Michael Roth Sorry I missed this before - please CC me on patches to the spapr code. I actually already wrote an equivalent patch and put it in spapr-next. > --- > hw/ppc/spapr_drc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c > index ee87432..0e7d725 100644 > --- a/hw/ppc/spapr_drc.c > +++ b/hw/ppc/spapr_drc.c > @@ -32,7 +32,7 @@ > =20 > #define DRC_CONTAINER_PATH "/dr-connector" > #define DRC_INDEX_TYPE_SHIFT 28 > -#define DRC_INDEX_ID_MASK (~(~0 << DRC_INDEX_TYPE_SHIFT)) > +#define DRC_INDEX_ID_MASK ((1 << DRC_INDEX_TYPE_SHIFT) - 1) > =20 > static sPAPRDRConnectorTypeShift get_type_shift(sPAPRDRConnectorType typ= e) > { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV5pYHAAoJEGw4ysog2bOS9IcQAKHkDQK6onS4Hunow7UsS0UC E/eFoP4SLdbIDmb4YFiYeIXGoQrwenPi66bcj2LMmIYShJONcgIMza+nK4n14Pu4 rF48YvzOHLSuILAJx2gsmmSo/E1eQqS4pMXDzFx3Olbb3H1m63FXUz15HRTf6tWX 57dCxIuCuHb5e6Qmd13HOH0okr7gyfaDPFWBLpjPyrHfillvJ1XqO+nwhuqA9NsZ PSYdl9PuwWGrRQgLMP/GUpu8+l452EbGCR0kGqPd/oK6Ykci/nWDeKxQsLWf6dKs Fj+rWIyuAdAOLMZCEE9zMlMbEWM5rE4yr1Ll/xEKJqdM4YkpL+4TO+CXjTgbOcPe v91h0jpbc4RBtyCk1ckKJ70L9u2jhD4uW+KWzhQ3fyJaXKXeaCakC8TZkRriShUf 3Z9onv3nGbe1VfhG470AgaNvGe5ZmDJFo+FgjDoIpHDgL2D85QN4Rddu7K2iewJf pJVOiwYHyY9TtaGevSRybLSVLe2hAJZIcBRwQ0Rqwt9OMj0+cwruVYoBCF5vCxMa vbjcOe3TpuwvsOdSibccTg2Z0BL3KJTnTfHAu5HVwigzuoPLFhhHCax2VFANJ8t7 SP63KtScq4hTKV84Y/EHXm7Ojl2CWpOwu15PmXVdaLDMkwtzbV/quJ52TrJqdpkq zf61NU8pnW15RPmHDUU9 =AFNT -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--