From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX32g-0002Gc-SZ for qemu-devel@nongnu.org; Wed, 02 Sep 2015 04:05:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX32d-0003Ip-NW for qemu-devel@nongnu.org; Wed, 02 Sep 2015 04:05:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX32d-0003Il-IQ for qemu-devel@nongnu.org; Wed, 02 Sep 2015 04:05:11 -0400 Date: Wed, 2 Sep 2015 10:05:06 +0200 From: Igor Mammedov Message-ID: <20150902100506.434cf538@nial.brq.redhat.com> In-Reply-To: <1439563931-12352-2-git-send-email-guangrong.xiao@linux.intel.com> References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com> <1439563931-12352-2-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 01/18] acpi: allow aml_operation_region() working on 64 bit offset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, rth@twiddle.net On Fri, 14 Aug 2015 22:51:54 +0800 Xiao Guangrong wrote: > Currently, the offset in OperationRegion is limited to 32 bit, extend it > to 64 bit so that we can switch SSDT to 64 bit in later patch > > Signed-off-by: Xiao Guangrong Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 2 +- > include/hw/acpi/aml-build.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 0d4b324..02f9e3d 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -752,7 +752,7 @@ Aml *aml_package(uint8_t num_elements) > > /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefOpRegion */ > Aml *aml_operation_region(const char *name, AmlRegionSpace rs, > - uint32_t offset, uint32_t len) > + uint64_t offset, uint32_t len) > { > Aml *var = aml_alloc(); > build_append_byte(var->buf, 0x5B); /* ExtOpPrefix */ > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index e3afa13..996ac5b 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -222,7 +222,7 @@ Aml *aml_interrupt(AmlConsumerAndProducer con_and_pro, > Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base, > uint8_t aln, uint8_t len); > Aml *aml_operation_region(const char *name, AmlRegionSpace rs, > - uint32_t offset, uint32_t len); > + uint64_t offset, uint32_t len); > Aml *aml_irq_no_flags(uint8_t irq); > Aml *aml_named_field(const char *name, unsigned length); > Aml *aml_reserved_field(unsigned length);