From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX588-0002ga-LG for qemu-devel@nongnu.org; Wed, 02 Sep 2015 06:19:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX585-0002XP-BU for qemu-devel@nongnu.org; Wed, 02 Sep 2015 06:19:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX585-0002X4-6k for qemu-devel@nongnu.org; Wed, 02 Sep 2015 06:18:57 -0400 Date: Wed, 2 Sep 2015 12:18:52 +0200 From: Igor Mammedov Message-ID: <20150902121852.584bc410@nial.brq.redhat.com> In-Reply-To: <1439563931-12352-5-git-send-email-guangrong.xiao@linux.intel.com> References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com> <1439563931-12352-5-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 04/18] acpi: add aml_sizeof List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, rth@twiddle.net On Fri, 14 Aug 2015 22:51:57 +0800 Xiao Guangrong wrote: > Implement SizeOf term which is used by NVDIMM _DSM method in later patch > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 8 ++++++++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 9e89efc..a526eed 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -1143,6 +1143,14 @@ Aml *aml_derefof(Aml *arg) > return var; > } > > +/* ACPI 6.0: 20.2.5.4 Type 2 Opcodes Encoding: DefSizeOf */ ditto, refer to to the first revision where it's appeared > +Aml *aml_sizeof(Aml *arg) > +{ > + Aml *var = aml_opcode(0x87 /* SizeOfOp */); > + aml_append(var, arg); > + return var; > +} > + > void > build_header(GArray *linker, GArray *table_data, > AcpiTableHeader *h, const char *sig, int len, uint8_t rev) > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 21dc5e9..6b591ab 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -276,6 +276,7 @@ Aml *aml_varpackage(uint32_t num_elements); > Aml *aml_touuid(const char *uuid); > Aml *aml_unicode(const char *str); > Aml *aml_derefof(Aml *arg); > +Aml *aml_sizeof(Aml *arg); > > void > build_header(GArray *linker, GArray *table_data,