From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41372)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZX7kb-0006dj-PH
	for qemu-devel@nongnu.org; Wed, 02 Sep 2015 09:06:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZX7kX-0005J9-CD
	for qemu-devel@nongnu.org; Wed, 02 Sep 2015 09:06:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46751)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZX7kX-0005J1-7v
	for qemu-devel@nongnu.org; Wed, 02 Sep 2015 09:06:49 -0400
Date: Wed, 2 Sep 2015 14:06:44 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150902130644.GA1924@stefanha-thinkpad.redhat.com>
References: <1441098383-22585-1-git-send-email-yanghy@cn.fujitsu.com>
	<1441098383-22585-2-git-send-email-yanghy@cn.fujitsu.com>
	<20150901143622.GC2407@stefanha-thinkpad.redhat.com>
	<55E6533F.30600@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55E6533F.30600@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v9 01/10] net: add a new object netfilter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas Faerber <afaerber@suse.de>

On Wed, Sep 02, 2015 at 09:39:11AM +0800, Yang Hongyang wrote:
> Hi Stefan,
> 
> On 09/01/2015 10:36 PM, Stefan Hajnoczi wrote:
> >On Tue, Sep 01, 2015 at 05:06:14PM +0800, Yang Hongyang wrote:
> >>Add the framework for a new netfilter object and a new
> >>-netfilter CLI option as a basis for the following patches.
> >>Note that the new added document in qemu-options.hx indicate that
> >>there's a buffer filter. This type of filter will be implemented
> >>in the following patches.
> >
> >Adding Markus and Andreas for the command-line and QAPI perspective on
> >adding a new type of object to QEMU.
> 
> I think I've already addressed Markus's comment of QAPI part on v8 :)

QAPI is about mapping to C structs, I think the real question I'm
raising is whether QOM should be used to avoid duplicating an object
model, lifecycle, etc.

Stefan