From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZX8PS-00035g-4v
	for qemu-devel@nongnu.org; Wed, 02 Sep 2015 09:49:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZX8PN-0007Nc-SH
	for qemu-devel@nongnu.org; Wed, 02 Sep 2015 09:49:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50822)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZX8PN-0007NQ-N2
	for qemu-devel@nongnu.org; Wed, 02 Sep 2015 09:49:01 -0400
Date: Wed, 2 Sep 2015 14:48:57 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150902134857.GB1924@stefanha-thinkpad.redhat.com>
References: <1439897142-28072-1-git-send-email-shmulik.ladkani@ravellosystems.com>
	<20150819184547.GA6800@dhcp-15-192.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150819184547.GA6800@dhcp-15-192.nay.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] net/vmxnet3: Flush packets when device
 gets activated
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>, Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>, qemu-devel@nongnu.org

On Thu, Aug 20, 2015 at 02:45:47AM +0800, Fam Zheng wrote:
> On Tue, 08/18 14:25, Shmulik Ladkani wrote:
> > As of a90a7425cf592a3afeff3eaf32f543b83050ee5c 'tap: Drop tap_can_send'
> > vmxnet3 (with tap networking) can no longer receive once device is
> > deactivated.
> > Alas, as the device is initially "inactive", this brakes vmxnet3
> > receive functionality.
> > 
> > vmxnet3_can_receive() checks its internal 'device_active' flag (among
> > other tests).
> > However, as of a90a7425cf, if 'device_active' is false, packets will be
> > queued by tap_send (at qemu_net_queue_send).
> > 
> > However, vmxnet3 never flushes the queue, even if the device is later
> > activated.
> > 
> > Fix by calling 'qemu_flush_queued_packets()' when vmxnet3 device gets
> > active.
> > 
> > Signed-off-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
> 
> Looks like the previous patch to fix this fell between the cracks and never
> made it to qemu.git?
> 
> http://patchwork.ozlabs.org/patch/489847/
> 
> Stefan, any idea?

Shmulik: Please test the patch that Fam linked