* [Qemu-devel] [PATCH] vmxnet3: Drop net_vmxnet3_info.can_receive
@ 2015-07-01 2:26 Fam Zheng
2015-07-02 13:07 ` Stefan Hajnoczi
2015-09-02 13:51 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Fam Zheng @ 2015-07-01 2:26 UTC (permalink / raw)
To: qemu-devel; +Cc: Dmitry Fleytman, jasowang, stefanha
Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the
semantics around .can_receive for sockets to now require the device to
flush queued pkts when transitioning to a .can_receive=true state. But
it's OK to drop incoming packets when the link is not active.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
hw/net/vmxnet3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 104a0f5..12ae30f 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -1929,7 +1929,6 @@ static void vmxnet3_set_link_status(NetClientState *nc)
static NetClientInfo net_vmxnet3_info = {
.type = NET_CLIENT_OPTIONS_KIND_NIC,
.size = sizeof(NICState),
- .can_receive = vmxnet3_can_receive,
.receive = vmxnet3_receive,
.link_status_changed = vmxnet3_set_link_status,
};
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vmxnet3: Drop net_vmxnet3_info.can_receive
2015-07-01 2:26 [Qemu-devel] [PATCH] vmxnet3: Drop net_vmxnet3_info.can_receive Fam Zheng
@ 2015-07-02 13:07 ` Stefan Hajnoczi
2015-09-02 13:51 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2015-07-02 13:07 UTC (permalink / raw)
To: Fam Zheng; +Cc: Dmitry Fleytman, jasowang, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
On Wed, Jul 01, 2015 at 10:26:27AM +0800, Fam Zheng wrote:
> Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the
> semantics around .can_receive for sockets to now require the device to
> flush queued pkts when transitioning to a .can_receive=true state. But
> it's OK to drop incoming packets when the link is not active.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/net/vmxnet3.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vmxnet3: Drop net_vmxnet3_info.can_receive
2015-07-01 2:26 [Qemu-devel] [PATCH] vmxnet3: Drop net_vmxnet3_info.can_receive Fam Zheng
2015-07-02 13:07 ` Stefan Hajnoczi
@ 2015-09-02 13:51 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2015-09-02 13:51 UTC (permalink / raw)
To: Fam Zheng; +Cc: Dmitry Fleytman, jasowang, qemu-devel
On Wed, Jul 01, 2015 at 10:26:27AM +0800, Fam Zheng wrote:
> Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the
> semantics around .can_receive for sockets to now require the device to
> flush queued pkts when transitioning to a .can_receive=true state. But
> it's OK to drop incoming packets when the link is not active.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/net/vmxnet3.c | 1 -
> 1 file changed, 1 deletion(-)
Sorry, this was dropped when waiting to see how the .can_receive() stuff
would end up for QEMU 2.4.
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-02 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 2:26 [Qemu-devel] [PATCH] vmxnet3: Drop net_vmxnet3_info.can_receive Fam Zheng
2015-07-02 13:07 ` Stefan Hajnoczi
2015-09-02 13:51 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).