Re: [Qemu-devel] [PATCH] ne2000: Drop ne2000_can_receive

[Stefan Hajnoczi <stefanha@redhat.com>]

On Wed, Jul 01, 2015 at 01:25:05PM +0800, Fam Zheng wrote:
> ne2000_receive already checks the same conditions and drops the packet
> if it's not ready, removing the .can_receive callback avoids the
> necessity to add explicit flushes when the conditions turn true (which
> is required by the new semantics of .can_receive since 6e99c63
> "net/socket: Drop net_socket_can_send").
> 
> Plus the "return 1" if E8390_STOP is also suspicious.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  hw/net/ne2000-isa.c |  1 -
>  hw/net/ne2000.c     | 10 ----------
>  hw/net/ne2000.h     |  1 -
>  3 files changed, 12 deletions(-)

Sorry, this was dropped and waiting to see how .can_receive() would turn
out for QEMU 2.4.

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan