From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX8Ry-0004wF-BG for qemu-devel@nongnu.org; Wed, 02 Sep 2015 09:51:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX8Rt-0000BY-TK for qemu-devel@nongnu.org; Wed, 02 Sep 2015 09:51:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX8Rt-0000BU-OU for qemu-devel@nongnu.org; Wed, 02 Sep 2015 09:51:37 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 236CA3DD42 for ; Wed, 2 Sep 2015 13:51:37 +0000 (UTC) Date: Wed, 2 Sep 2015 14:51:32 +0100 From: Stefan Hajnoczi Message-ID: <20150902135132.GD1924@stefanha-thinkpad.redhat.com> References: <1435728305-5064-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435728305-5064-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] ne2000: Drop ne2000_can_receive List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: jasowang@redhat.com, qemu-devel@nongnu.org On Wed, Jul 01, 2015 at 01:25:05PM +0800, Fam Zheng wrote: > ne2000_receive already checks the same conditions and drops the packet > if it's not ready, removing the .can_receive callback avoids the > necessity to add explicit flushes when the conditions turn true (which > is required by the new semantics of .can_receive since 6e99c63 > "net/socket: Drop net_socket_can_send"). > > Plus the "return 1" if E8390_STOP is also suspicious. > > Signed-off-by: Fam Zheng > --- > hw/net/ne2000-isa.c | 1 - > hw/net/ne2000.c | 10 ---------- > hw/net/ne2000.h | 1 - > 3 files changed, 12 deletions(-) Sorry, this was dropped and waiting to see how .can_receive() would turn out for QEMU 2.4. Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan