From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXHeR-0008Ou-QZ for qemu-devel@nongnu.org; Wed, 02 Sep 2015 19:41:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXHeN-00085D-UV for qemu-devel@nongnu.org; Wed, 02 Sep 2015 19:41:11 -0400 Date: Thu, 3 Sep 2015 09:18:02 +1000 From: David Gibson Message-ID: <20150902231802.GB6537@voom.redhat.com> References: <1441186198-991-1-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FkmkrVfFsRoUs1wW" Content-Disposition: inline In-Reply-To: <1441186198-991-1-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu] spapr: Enable in-kernel H_SET_MODE handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --FkmkrVfFsRoUs1wW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 02, 2015 at 07:29:58PM +1000, Alexey Kardashevskiy wrote: > For setting debug watchpoints, sPAPR guests use H_SET_MODE hypercall. > The existing QEMU H_SET_MODE handler does not support this but > the KVM handler in HV KVM does. However it is not enabled. >=20 > This enables the in-kernel H_SET_MODE handler which handles: > - Completed Instruction Address Breakpoint Register > - Watch point 0 registers. >=20 > The rest is still handled in QEMU. >=20 > Reported-by: Anton Blanchard > Signed-off-by: Alexey Kardashevskiy Won't this break auto-switching of VGA endianness, since that is triggered from the qemu implementation of H_SET_MODE? > --- > hw/ppc/spapr.c | 1 + > target-ppc/kvm.c | 5 +++++ > target-ppc/kvm_ppc.h | 5 +++++ > 3 files changed, 11 insertions(+) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index ae82565..7df0e15 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -1728,6 +1728,7 @@ static void ppc_spapr_init(MachineState *machine) > if (kvm_enabled()) { > /* Enable H_LOGICAL_CI_* so SLOF can talk to in-kernel devices */ > kvmppc_enable_logical_ci_hcalls(); > + kvmppc_enable_set_mode_hcall(); > } > =20 > /* allocate RAM */ > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c > index 110436d..9cf5308 100644 > --- a/target-ppc/kvm.c > +++ b/target-ppc/kvm.c > @@ -1953,6 +1953,11 @@ void kvmppc_enable_logical_ci_hcalls(void) > kvmppc_enable_hcall(kvm_state, H_LOGICAL_CI_STORE); > } > =20 > +void kvmppc_enable_set_mode_hcall(void) > +{ > + kvmppc_enable_hcall(kvm_state, H_SET_MODE); > +} > + > void kvmppc_set_papr(PowerPCCPU *cpu) > { > CPUState *cs =3D CPU(cpu); > diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h > index 4d30e27..0714ba0 100644 > --- a/target-ppc/kvm_ppc.h > +++ b/target-ppc/kvm_ppc.h > @@ -25,6 +25,7 @@ int kvmppc_get_hasidle(CPUPPCState *env); > int kvmppc_get_hypercall(CPUPPCState *env, uint8_t *buf, int buf_len); > int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level); > void kvmppc_enable_logical_ci_hcalls(void); > +void kvmppc_enable_set_mode_hcall(void); > void kvmppc_set_papr(PowerPCCPU *cpu); > int kvmppc_set_compat(PowerPCCPU *cpu, uint32_t cpu_version); > void kvmppc_set_mpic_proxy(PowerPCCPU *cpu, int mpic_proxy); > @@ -112,6 +113,10 @@ static inline void kvmppc_enable_logical_ci_hcalls(v= oid) > { > } > =20 > +static inline void kvmppc_enable_set_mode_hcall(void) > +{ > +} > + > static inline void kvmppc_set_papr(PowerPCCPU *cpu) > { > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --FkmkrVfFsRoUs1wW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV54OqAAoJEGw4ysog2bOSo1oP/0H6mk9wAHHCkazaj7p5R30j aBSOVkZIBJz0G44dOyC2KKVihqmTrhJQD72if0SrWGvOU+l0jwA8Zxm3i7Ud+a3K 7uORfbTMQKPn6r/pDYjS2akV+CMcot/tJ2eWHxqQ3rTd7s3RVWDyL1OgvI0dSClr wWC/ga3sSX5t+qw7vw5OkZ7hEH/f+H8e+1k4QsFbVi5qtJ/H1gvrFkqQXr8kumsB OW/cHmLPepwYepf42OhztFQ9tc+0RXjhqKtlbLjSEIx78kSbFfzfTJmNLNrDcMH5 jUGBewzVnLm/r1DtChUt2lqzHbmg0PS46sT/7KN9PHwA4siiUFd+BSzvmesr3vEm 7fQxSpyeMHYas7kNbUaXxXcY67HKAgsHn1Tzj2vTOm9360qvY2EVWMDHQYdkH9mX Me6NRzhvxB2F2TXuBgQ2bhTcOqRfNSrgyOjKYS25bwHkWsBVhpYyHorsnFW+9n2H qorMxlkzH8v2141HHSQvF2S4QKXXtwN6HlhM3ez7qxHPE3QatciyJLtbHwsfTuDs /375qwK5JQrA3n5X3vfhcn7as0UhSHk2a4BnbE8JNPsvKM4LJKuFcJc9mn7c0egS LINU9yWOlWlIxFt/Ba56s0GtN6Q2UgFg8xezj/eqt+OSMwHlgLuKZfwaIb7A8et2 N+upPVZ2DLKS1KleVviv =xqVS -----END PGP SIGNATURE----- --FkmkrVfFsRoUs1wW--