From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33435)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXVY4-0005ry-MW
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:31:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXVY0-0005xB-Ml
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:31:32 -0400
Date: Thu, 3 Sep 2015 15:31:23 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150903143123.GA17710@stefanha-thinkpad.redhat.com>
References: <1435611386-29316-1-git-send-email-jsnow@redhat.com>
	<20150709102623.GC28530@stefanha-thinkpad.redhat.com>
	<55DBB496.2070605@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55DBB496.2070605@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] trivial: remove trailing newline from
 error_report
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org

On Mon, Aug 24, 2015 at 08:19:34PM -0400, John Snow wrote:
> 
> 
> On 07/09/2015 06:26 AM, Stefan Hajnoczi wrote:
> > On Mon, Jun 29, 2015 at 04:56:26PM -0400, John Snow wrote:
> >> Minor cleanup.
> >> 
> >> Signed-off-by: John Snow <jsnow@redhat.com> --- hw/ide/ahci.c
> >> | 2 +- hw/vfio/platform.c | 2 +- net/tap-linux.c    | 4 ++-- 3
> >> files changed, 4 insertions(+), 4 deletions(-)
> > 
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > 
> > Laszlo Ersek suggested a compile-time check (e.g. BUILD_BUG_ON()).
> > Have you looked into this?
> > 
> > Perhaps something along the lines of:
> > 
> > BUILD_BUG_ON(__builtin_constant_p(fmt) && __builtin_strlen(fmt) > 0
> > && fmt[__builtin_strlen(fmt) - 1] == '\n')
> > 
> 
> ping for 2.5; I don't think this ever made it in.

CCing Michael explicitly since this is for the trivial tree