From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45045)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXVwH-0005d6-Ue
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:56:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXVwE-0002kO-Q6
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:56:33 -0400
Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:35496)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXVwE-0002k1-IP
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:56:30 -0400
Received: by wicge5 with SMTP id ge5so76920648wic.0
	for <qemu-devel@nongnu.org>; Thu, 03 Sep 2015 07:56:29 -0700 (PDT)
Date: Thu, 3 Sep 2015 15:56:26 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150903145626.GA18405@stefanha-thinkpad.redhat.com>
References: <1439839233-27204-1-git-send-email-kevin@koconnor.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1439839233-27204-1-git-send-email-kevin@koconnor.net>
Subject: Re: [Qemu-devel] [RESEND PATCHv2] sdhci: Pass drive parameter to
 sdhci-pci via qdev property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Mon, Aug 17, 2015 at 03:20:33PM -0400, Kevin O'Connor wrote:
> Commit 19109131 disabled the sdhci-pci support because it used
> drive_get_next().  This patch reenables sdhci-pci and changes it to
> pass the drive via a qdev property - for example:
>  -device sdhci-pci,drive=drive0 -drive id=drive0,if=sd,file=myimage
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
> ---
> 
> This is a resend of the patch I sent two weeks ago.  No changes (other
> than adding Stefan's reviewed-by line).
> 
> v2:
> - Don't call blk_detach_dev() in sdhci pci code - instead change
>   sd_init() to use blk_attach_dev() instead of blk_attach_dev_nofail().
> 
> ---
>  hw/sd/sd.c    |  4 +++-
>  hw/sd/sdhci.c | 32 +++++++++++++++++++-------------
>  hw/sd/sdhci.h |  2 ++
>  3 files changed, 24 insertions(+), 14 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan