From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXWD4-0004Bd-B6 for qemu-devel@nongnu.org; Thu, 03 Sep 2015 11:13:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXWD3-0002RL-HW for qemu-devel@nongnu.org; Thu, 03 Sep 2015 11:13:54 -0400 Date: Thu, 3 Sep 2015 17:13:44 +0200 From: Kevin Wolf Message-ID: <20150903151344.GC8138@noname.redhat.com> References: <1440111638-30188-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440111638-30188-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qemu-img: Fix crash in amend invocation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-stable@nongnu.org Am 21.08.2015 um 01:00 hat Max Reitz geschrieben: > Example: > $ ./qemu-img create -f qcow2 /tmp/t.qcow2 64M > $ ./qemu-img amend -f qcow2 -o backing_file=/tmp/t.qcow2, -o help \ > /tmp/t.qcow2 > > This should not crash. This actually is tested by iotest 082, but not > caught due to the segmentation fault being silent (which is something > that needs to be fixed, too). > > Reported-by: Dr. David Alan Gilbert > Cc: qemu-stable > Signed-off-by: Max Reitz > --- > v2: > - Fix leak introduced by trying to be clever [Eric] > (thank you for catching this!) Thanks, applied to the block branch. Kevin