From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54930)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXXSA-0005ae-LT
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 12:33:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXXS6-0007sF-LR
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 12:33:34 -0400
Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:37641)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXXS6-0007sB-F1
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 12:33:30 -0400
Received: by wicfx3 with SMTP id fx3so58383396wic.0
	for <qemu-devel@nongnu.org>; Thu, 03 Sep 2015 09:33:29 -0700 (PDT)
Date: Thu, 3 Sep 2015 17:33:16 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150903163316.GC18405@stefanha-thinkpad.redhat.com>
References: <1439798975-2488-1-git-send-email-markmb@redhat.com>
	<1439798975-2488-2-git-send-email-markmb@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1439798975-2488-2-git-send-email-markmb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add dynamic module loading for block
 drivers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marc =?iso-8859-1?Q?Mar=ED?= <markmb@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Mon, Aug 17, 2015 at 10:09:34AM +0200, Marc Marí wrote:
> +static const struct {
> +    const char *format_name;
> +    const char *protocol_name;
> +    const char *library_name;
> +    bool has_probe;
> +    bool has_probe_device;
> +} block_driver_module[] = {

Why is this list incomplete?  It doesn't cover all block drivers.
Perhaps these are the only modular block drivers.

Also, it ignores CONFIG_CURL and friends.  Perhaps it doesn't matter
because the module loading code will just see that there is no file
there, but maybe conditional compilation should be used?

A plural name would more consistent (i.e. you deleted the
plural block_modules[] variable and introduced a singular
block_driver_module[] variable).