From: Stefan Hajnoczi <stefanha@gmail.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: gkurz@linux.vnet.ibm.com,
Pierre Morel <pmorel@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1
Date: Thu, 3 Sep 2015 18:08:42 +0100 [thread overview]
Message-ID: <20150903170842.GH18405@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20150826145545.1de87360.cornelia.huck@de.ibm.com>
On Wed, Aug 26, 2015 at 02:55:45PM +0200, Cornelia Huck wrote:
> On Wed, 26 Aug 2015 13:50:52 +0100
> Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> > On Tue, Aug 25, 2015 at 12:33:30PM +0200, Pierre Morel wrote:
> > > - vring_init(&vring->vr, virtio_queue_get_num(vdev, n), vring_ptr, 4096);
> >
> > vring_init() is no longer used. Please delete it.
> >
>
> vring_init() is defined in a header imported from Linux.
You are right, I was confused. The grep output shows we have two
vring_init() in QEMU:
include/standard-headers/linux/virtio_ring.h:static inline void vring_init(struct vring *vr, unsigned int num, void *p,
pc-bios/s390-ccw/virtio.c:static void vring_init(struct vring *vr, unsigned int num, void *p,
next prev parent reply other threads:[~2015-09-03 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 10:33 [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1 Pierre Morel
2015-08-26 11:29 ` Greg Kurz
2015-08-26 11:51 ` Pierre Morel
2015-08-26 12:50 ` Stefan Hajnoczi
2015-08-26 12:55 ` Cornelia Huck
2015-09-03 17:08 ` Stefan Hajnoczi [this message]
2015-09-04 6:37 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903170842.GH18405@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).