From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41141)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXY0I-0007sJ-4E
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 13:08:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXY0E-0000Gq-Um
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 13:08:50 -0400
Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:38264)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZXY0E-0000Gk-NW
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 13:08:46 -0400
Received: by wiclk2 with SMTP id lk2so15292344wic.1
	for <qemu-devel@nongnu.org>; Thu, 03 Sep 2015 10:08:46 -0700 (PDT)
Date: Thu, 3 Sep 2015 18:08:42 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150903170842.GH18405@stefanha-thinkpad.redhat.com>
References: <1440498810-17354-1-git-send-email-pmorel@linux.vnet.ibm.com>
	<20150826125052.GI30715@stefanha-thinkpad.redhat.com>
	<20150826145545.1de87360.cornelia.huck@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150826145545.1de87360.cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for
 virtio Version 1
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: gkurz@linux.vnet.ibm.com, Pierre Morel <pmorel@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, mst@redhat.com

On Wed, Aug 26, 2015 at 02:55:45PM +0200, Cornelia Huck wrote:
> On Wed, 26 Aug 2015 13:50:52 +0100
> Stefan Hajnoczi <stefanha@redhat.com> wrote:
> 
> > On Tue, Aug 25, 2015 at 12:33:30PM +0200, Pierre Morel wrote:
> > > -    vring_init(&vring->vr, virtio_queue_get_num(vdev, n), vring_ptr, 4096);
> > 
> > vring_init() is no longer used.  Please delete it.
> > 
> 
> vring_init() is defined in a header imported from Linux.

You are right, I was confused.  The grep output shows we have two
vring_init() in QEMU:

include/standard-headers/linux/virtio_ring.h:static inline void vring_init(struct vring *vr, unsigned int num, void *p,
pc-bios/s390-ccw/virtio.c:static void vring_init(struct vring *vr, unsigned int num, void *p,