From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57840)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <markmb@redhat.com>) id 1ZXYpd-00043B-O7
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 14:01:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <markmb@redhat.com>) id 1ZXYpa-0007pF-CC
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 14:01:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42210)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <markmb@redhat.com>) id 1ZXYpa-0007ox-88
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 14:01:50 -0400
Date: Thu, 3 Sep 2015 20:01:44 +0200
From: Marc =?UTF-8?B?TWFyw60=?= <markmb@redhat.com>
Message-ID: <20150903200144.781dd083@markmb_rh>
In-Reply-To: <20150903163316.GC18405@stefanha-thinkpad.redhat.com>
References: <1439798975-2488-1-git-send-email-markmb@redhat.com>
	<1439798975-2488-2-git-send-email-markmb@redhat.com>
	<20150903163316.GC18405@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/2] Add dynamic module loading for block
 drivers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Thu, 3 Sep 2015 17:33:16 +0100
Stefan Hajnoczi <stefanha@gmail.com> wrote:

> On Mon, Aug 17, 2015 at 10:09:34AM +0200, Marc Mar=C3=AD wrote:
> > +static const struct {
> > +    const char *format_name;
> > +    const char *protocol_name;
> > +    const char *library_name;
> > +    bool has_probe;
> > +    bool has_probe_device;
> > +} block_driver_module[] =3D {
>=20
> Why is this list incomplete?  It doesn't cover all block drivers.
> Perhaps these are the only modular block drivers.

I think we can decide on a protocol first (these patches), and then
apply the changes to all (possible) drivers. At least, that was what I
had in mind.

> Also, it ignores CONFIG_CURL and friends.  Perhaps it doesn't matter
> because the module loading code will just see that there is no file
> there, but maybe conditional compilation should be used?

It's true that this patch doesn't look at the CONFIG options. But the
next one does (it takes block-obj-m from the Makefile), and also
replaces this file.

Thanks
Marc

> A plural name would more consistent (i.e. you deleted the
> plural block_modules[] variable and introduced a singular
> block_driver_module[] variable).