From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXacV-0000hn-Qb for qemu-devel@nongnu.org; Thu, 03 Sep 2015 15:56:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXacU-0005mI-Pf for qemu-devel@nongnu.org; Thu, 03 Sep 2015 15:56:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXacU-0005mE-KZ for qemu-devel@nongnu.org; Thu, 03 Sep 2015 15:56:26 -0400 Date: Thu, 3 Sep 2015 22:56:22 +0300 From: "Michael S. Tsirkin" Message-ID: <20150903225605-mutt-send-email-mst@redhat.com> References: <1441220618-4750-1-git-send-email-rjones@redhat.com> <1441220618-4750-2-git-send-email-rjones@redhat.com> <20150903000816-mutt-send-email-mst@redhat.com> <55E862A3.4070702@redhat.com> <55E8646F.20401@msgid.tls.msk.ru> <55E8692B.5070201@redhat.com> <55E8764D.6020302@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E8764D.6020302@msgid.tls.msk.ru> Subject: Re: [Qemu-devel] [PATCH 1/2] acpi: Allow ACPI default OEM ID and OEM table ID fields to be set. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: peter.maydell@linaro.org, ehabkost@redhat.com, imammedo@redhat.com, qemu-devel@nongnu.org, "Richard W.M. Jones" , zhaoshenglong@huawei.com, pbonzini@redhat.com, Laszlo Ersek , rth@twiddle.net On Thu, Sep 03, 2015 at 07:33:17PM +0300, Michael Tokarev wrote: > 03.09.2015 18:37, Laszlo Ersek wrote: > [] > > Actually, 6 + 4 + 4 = 14, so OemID and OemTableID. But, you are right, I > > was working off the commit message & comments only, not the actual > > amount of bytes copied. > > > > This ties down both OemID and OemTableId, between all of RSDT, SLIC, and > > FADT. Since > > - I argue against exposing a generic oem_table_id on the command > > line (unlike oem_id), > > - and I also find that an oem_table_id "map" would be overkill, > > > > I think it follows that I can only ask for the special SLIC-handling > > logic already visible in your patch. "User passed in SLIC --> adapt RSDT > > and FADT." That is, it is already user-controlled. > > It might be useful to have it controllable by user in other cases too. > But I don't have any usage case for that. > > > (The FADT change will ensure that OVMF will update the RSDT that *it* > > installs.) > > > > This is just my preference, of course... But at least it doesn't seem to > > conflict with Michael's! :) > > Yes, it might just work. Especially since in case when SLIC is specified, > the oem_table&Co should come from SLIC, not forcing user to specify them > on command line. Command line can be used anyway, with the default value > coming from slic if it is provided. > > BTW, I updated the patch for 2.4 a few days ago, it is hackish as I wanted > to touch as few files as possible. > > And BTW2, the code in acpi/core.c uses its own local definition of ACPI > table data structures, instead of using common code from acpi.h... ;) > > Thanks, > > /mjt Yes, we want that cleaned up.