From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXeUJ-0001qx-L1 for qemu-devel@nongnu.org; Thu, 03 Sep 2015 20:04:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXeUG-0001ct-Bk for qemu-devel@nongnu.org; Thu, 03 Sep 2015 20:04:15 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:35246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXeUG-0001cf-7h for qemu-devel@nongnu.org; Thu, 03 Sep 2015 20:04:12 -0400 Received: from /spool/local by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Sep 2015 20:04:11 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 81DE6C90042 for ; Thu, 3 Sep 2015 19:55:12 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t840488s55247068 for ; Fri, 4 Sep 2015 00:04:08 GMT Received: from d01av02.pok.ibm.com (localhost [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t84048tT020873 for ; Thu, 3 Sep 2015 20:04:08 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth References: <1441290623-13631-1-git-send-email-armbru@redhat.com> <1441290623-13631-31-git-send-email-armbru@redhat.com> <55E8B288.3090700@redhat.com> In-Reply-To: <55E8B288.3090700@redhat.com> Message-ID: <20150904000405.10296.82922@loki> Date: Thu, 03 Sep 2015 19:04:05 -0500 Subject: Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Markus Armbruster , qemu-devel@nongnu.org Quoting Eric Blake (2015-09-03 15:50:16) > On 09/03/2015 08:30 AM, Markus Armbruster wrote: > > qapi/introspect.json defines the introspection schema. It's designed > > for QMP introspection, but should do for similar uses, such as QGA. > = > [review to follow in separate message; I'm using this message to focus > on one point for easier tracking of the sub-thread] > = > > = > > The introspection schema does not reflect all the rules and > > restrictions that apply to QAPI schemata. A valid QAPI schema has an > > introspection value conforming to the introspection schema, but the > > converse is not true. > > = > > Introspection lowers away a number of schema details, and makes > > implicit things explicit: > > = > > * The built-in types are declared with their JSON type. > > = > > TODO Should we map all the integer types to just int? > = > So, given the discussion on v3, I think we will have consensus if v5 > does the following: > = > - Merge 30 and 31 into a single patch, and drop this TODO statement (I > think we have agreement that exposing QMP [that is, JSON number] wire > form, with no additional constraints, as a single 'int', rather than the > underlying generated C types, is the way to go), provided that... > - Document in the qapi side that the schema intentionally lacks details > on ranges, and that consulting the qapi and/or C code may be required to > see what actual values are valid anywhere introspection merely says 'int', > - leave 32 as a separate patch, as it is complex enough, and still may > have debate on whether the types '123' and 'int' should have > corresponding array types '[123]' and '[int]' rather than the v3 patch > munging of '456' and '789' (I haven't yet reviewed whether v4 changed tha= t). Agreed on all 3 > = > Any further arguments on whether exposing just 'int' in the > introspection for all integral types, and/or whether patches 30 and 31 > should be merged, are best made in response to this mail. Given the above, I don't think I have any further objections. > = > -- = > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >=20