From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXlJR-0000Zb-Ig for qemu-devel@nongnu.org; Fri, 04 Sep 2015 03:21:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXlJO-0000u9-Fk for qemu-devel@nongnu.org; Fri, 04 Sep 2015 03:21:29 -0400 Date: Fri, 4 Sep 2015 17:10:11 +1000 From: David Gibson Message-ID: <20150904071011.GC6537@voom.redhat.com> References: <1439967371-15870-1-git-send-email-bharata@linux.vnet.ibm.com> <1439967371-15870-3-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jSXJDi5r/aeatSyx" Content-Disposition: inline In-Reply-To: <1439967371-15870-3-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v0 2/3] spapr-rtas: Enable rtas_set_indicator() to return correct error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com --jSXJDi5r/aeatSyx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 19, 2015 at 12:26:10PM +0530, Bharata B Rao wrote: > drck->set_isolation_state() can return error. For such a case ensure > correct error is returned by rtas_set_indicator() instead of always > returning success. >=20 > TODO: rtas_st(, , uint32 val) =3D> the return value uint32, but > drck->set_[allocation/indicator/isolation]_state() is returning int. > Should we change this return value to uint32_t to match with rtas_st() > argument ? >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson > --- > hw/ppc/spapr_rtas.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > index e99e25f..96729b4 100644 > --- a/hw/ppc/spapr_rtas.c > +++ b/hw/ppc/spapr_rtas.c > @@ -374,6 +374,7 @@ static void rtas_set_indicator(PowerPCCPU *cpu, sPAPR= MachineState *spapr, > uint32_t sensor_state; > sPAPRDRConnector *drc; > sPAPRDRConnectorClass *drck; > + int ret; > =20 > if (nargs !=3D 3 || nret !=3D 1) { > rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR); > @@ -413,19 +414,19 @@ static void rtas_set_indicator(PowerPCCPU *cpu, sPA= PRMachineState *spapr, > spapr_ccs_remove(spapr, ccs); > } > } > - drck->set_isolation_state(drc, sensor_state); > + ret =3D drck->set_isolation_state(drc, sensor_state); > break; > case RTAS_SENSOR_TYPE_DR: > - drck->set_indicator_state(drc, sensor_state); > + ret =3D drck->set_indicator_state(drc, sensor_state); > break; > case RTAS_SENSOR_TYPE_ALLOCATION_STATE: > - drck->set_allocation_state(drc, sensor_state); > + ret =3D drck->set_allocation_state(drc, sensor_state); > break; > default: > goto out_unimplemented; > } > =20 > - rtas_st(rets, 0, RTAS_OUT_SUCCESS); > + rtas_st(rets, 0, ret); > return; > =20 > out_unimplemented: --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --jSXJDi5r/aeatSyx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV6UPSAAoJEGw4ysog2bOSHNYP/3JdCsxStfy2l6vnZOJVF2lp 2+S2gR3sCfvECpafW8SKUDVkX0gj+AjWNF9JM0aLf8WdNsGCsfnjivCZdKn2vvIF zFpm0K0QD15l7SfZEjHs+f+zpvIeinFJKNl5o9WZ7K+yve9pdmY3WxUXV4oDoVPh 8VAC7ZpQ/sVRdeg/1bW83UF9hotF+/bFbXaPw0eT6hhlfpuEU/Pr636N2zqs7lzL 2eUGoUnDgn9wiM6ZLSYznA87Qa3uJiRzkneZuQn7HDY09baDqw5NeoM/I4f4pOKV OW42gWSa4uCKbjbmD0qVkAkGpYVvn+l1NHjkr4cg3R6iiuZ2VBZjXrE5eIHsiFZ8 rF08y72n3HFOdFvZQ7l0ZDVvcN67JdIRTOyWFHK9KU+4o7FXAwu0X2pPql8DnO2n zAFy11YV+661xWifyQ/V3tVbfG/PesBPi5pGyPTvHohqdd/lFC5eX3voyiKvK/PO bpCPeSPls/j1fYRqzMHtGozH9rIiWn5OrAx57WsUCDwBO3wntbFNXRDBYx1ebE3k NcKLw2jcibnA+EOY7XCUhZtvDHtQh22sQDg45Kw8oWBMw06l/pju9l5+T2YdYe9l FQR6IuAh1vLpTj3q9AzQpktequnksxCqPrgD1ryP0fxvGrOt+hioyJW13b+6Ke8h PLOjho5X13ARtCLMjK2K =Ku13 -----END PGP SIGNATURE----- --jSXJDi5r/aeatSyx--