From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYoHO-0006I3-9I for qemu-devel@nongnu.org; Mon, 07 Sep 2015 00:43:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYoHN-0002Hn-G3 for qemu-devel@nongnu.org; Mon, 07 Sep 2015 00:43:42 -0400 Date: Mon, 7 Sep 2015 12:43:32 +0800 From: Fam Zheng Message-ID: <20150907044332.GA3958@ad.nay.redhat.com> References: <1438144934-23619-1-git-send-email-famz@redhat.com> <1438144934-23619-4-git-send-email-famz@redhat.com> <20150827135352.GC4917@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150827135352.GC4917@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers as "protocol" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com On Thu, 08/27 14:53, Stefan Hajnoczi wrote: > On Wed, Jul 29, 2015 at 12:42:06PM +0800, Fam Zheng wrote: > > diff --git a/include/block/aio.h b/include/block/aio.h > > index bd1d44b..d02ddfa 100644 > > --- a/include/block/aio.h > > +++ b/include/block/aio.h > > @@ -273,6 +273,7 @@ bool aio_pending(AioContext *ctx); > > bool aio_dispatch(AioContext *ctx); > > > > #define AIO_CLIENT_UNSPECIFIED (1 << 0) > > +#define AIO_CLIENT_PROTOCOL (1 << 1) > > The semantics need to be documented here, not just in the commit > description. > > AIO_CLIENT_BLOCK_DRIVER or AIO_CLIENT_BLOCK_PROTOCOL seems like a > clearer name to me since "protocol" just by itself could mean many > things. OK, renaming to AIO_CLIENT_BLOCK_DRIVER. Thanks, Fam