From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYryO-00018r-SP for qemu-devel@nongnu.org; Mon, 07 Sep 2015 04:40:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYryI-0000EU-WC for qemu-devel@nongnu.org; Mon, 07 Sep 2015 04:40:20 -0400 Received: from mail.ispras.ru ([83.149.199.45]:52469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYryI-0000ED-PO for qemu-devel@nongnu.org; Mon, 07 Sep 2015 04:40:14 -0400 From: Pavel Dovgalyuk Date: Mon, 07 Sep 2015 11:40:14 +0300 Message-ID: <20150907084014.1664.19748.stgit@PASHA-ISP> In-Reply-To: <20150907084005.1664.19540.stgit@PASHA-ISP> References: <20150907084005.1664.19540.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v17 01/21] i386: partial revert of interrupt poll fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, igor.rubinov@gmail.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, hines@cert.org, fred.konrad@greensocs.com Processing CPU_INTERRUPT_POLL requests in cpu_has_work functions break the determinism of cpu_exec. This patch is required to make interrupts processing deterministic. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c | 9 +++++++++ target-i386/cpu.c | 10 ++-------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 6b6942d..1f8046f 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -28,6 +28,9 @@ #include "exec/memory-internal.h" #include "qemu/rcu.h" #include "exec/tb-hash.h" +#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY) +#include "hw/i386/apic.h" +#endif /* -icount align implementation. */ @@ -369,6 +372,12 @@ int cpu_exec(CPUState *cpu) volatile bool have_tb_lock = false; if (cpu->halted) { +#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY) + if (cpu->interrupt_request & CPU_INTERRUPT_POLL) { + apic_poll_irq(x86_cpu->apic_state); + cpu_reset_interrupt(cpu, CPU_INTERRUPT_POLL); + } +#endif if (!cpu_has_work(cpu)) { return EXCP_HALTED; } diff --git a/target-i386/cpu.c b/target-i386/cpu.c index cfb8aa7..3d2e2f0 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -3098,14 +3098,8 @@ static bool x86_cpu_has_work(CPUState *cs) X86CPU *cpu = X86_CPU(cs); CPUX86State *env = &cpu->env; -#if !defined(CONFIG_USER_ONLY) - if (cs->interrupt_request & CPU_INTERRUPT_POLL) { - apic_poll_irq(cpu->apic_state); - cpu_reset_interrupt(cs, CPU_INTERRUPT_POLL); - } -#endif - - return ((cs->interrupt_request & CPU_INTERRUPT_HARD) && + return ((cs->interrupt_request & (CPU_INTERRUPT_HARD | + CPU_INTERRUPT_POLL)) && (env->eflags & IF_MASK)) || (cs->interrupt_request & (CPU_INTERRUPT_NMI | CPU_INTERRUPT_INIT |