From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Alberto Garcia <berto@igalia.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/5] block: Drop drv parameter from bdrv_open()
Date: Mon, 7 Sep 2015 12:25:28 +0200 [thread overview]
Message-ID: <20150907102528.GA5529@noname.redhat.com> (raw)
In-Reply-To: <1440611272-4571-1-git-send-email-mreitz@redhat.com>
Am 26.08.2015 um 19:47 hat Max Reitz geschrieben:
> We don't really need that parameter, so let's drop it. Doing so may even
> fix some bugs, see
> http://lists.nongnu.org/archive/html/qemu-block/2015-08/msg00171.html.
>
> In the course of writing this series, I had to decide whether the make
> sure all callers of bdrv_find_whitelisted_format() would still only
> accept whitelisted formats, which you'd think would be a good idea; but
> the only caller left was qmp_change_blockdev(), so I guess noone really
> cared about it anymore, instead relying on use_bdrv_whitelist alone.
>
> So I decided dropped bdrv_find_whitelisted_format() completely. If you
> feel this is a bad decision, feel free to argue but then I guess we'll
> have to reevaluate all bdrv_find_format() calls whether they should
> actually be bdrv_find_whitelisted_format() calls.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2015-09-07 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 17:47 [Qemu-devel] [PATCH 0/5] block: Drop drv parameter from bdrv_open() Max Reitz
2015-08-26 17:47 ` [Qemu-devel] [PATCH 1/5] block: Always pass NULL as drv for bdrv_open() Max Reitz
2015-08-27 6:54 ` Alberto Garcia
2015-08-26 17:47 ` [Qemu-devel] [PATCH 2/5] block: Drop drv parameter from bdrv_open() Max Reitz
2015-08-27 6:55 ` Alberto Garcia
2015-08-26 17:47 ` [Qemu-devel] [PATCH 3/5] block: Drop drv parameter from bdrv_open_inherit() Max Reitz
2015-08-27 6:55 ` Alberto Garcia
2015-08-26 17:47 ` [Qemu-devel] [PATCH 4/5] block: Drop drv parameter from bdrv_fill_options() Max Reitz
2015-08-27 6:55 ` Alberto Garcia
2015-08-26 17:47 ` [Qemu-devel] [PATCH 5/5] block: Drop bdrv_find_whitelisted_format() Max Reitz
2015-08-27 6:56 ` Alberto Garcia
2015-09-07 10:25 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907102528.GA5529@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).