From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYtcF-0003n9-JK for qemu-devel@nongnu.org; Mon, 07 Sep 2015 06:25:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYtcE-0003qR-Mh for qemu-devel@nongnu.org; Mon, 07 Sep 2015 06:25:35 -0400 Date: Mon, 7 Sep 2015 12:25:28 +0200 From: Kevin Wolf Message-ID: <20150907102528.GA5529@noname.redhat.com> References: <1440611272-4571-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440611272-4571-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/5] block: Drop drv parameter from bdrv_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Alberto Garcia , qemu-devel@nongnu.org, qemu-block@nongnu.org Am 26.08.2015 um 19:47 hat Max Reitz geschrieben: > We don't really need that parameter, so let's drop it. Doing so may even > fix some bugs, see > http://lists.nongnu.org/archive/html/qemu-block/2015-08/msg00171.html. > > In the course of writing this series, I had to decide whether the make > sure all callers of bdrv_find_whitelisted_format() would still only > accept whitelisted formats, which you'd think would be a good idea; but > the only caller left was qmp_change_blockdev(), so I guess noone really > cared about it anymore, instead relying on use_bdrv_whitelist alone. > > So I decided dropped bdrv_find_whitelisted_format() completely. If you > feel this is a bad decision, feel free to argue but then I guess we'll > have to reevaluate all bdrv_find_format() calls whether they should > actually be bdrv_find_whitelisted_format() calls. Thanks, applied to the block branch. Kevin