From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYvS7-0000rx-1E for qemu-devel@nongnu.org; Mon, 07 Sep 2015 08:23:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYvS6-0001UE-0r for qemu-devel@nongnu.org; Mon, 07 Sep 2015 08:23:15 -0400 Date: Mon, 7 Sep 2015 14:23:02 +0200 From: Kevin Wolf Message-ID: <20150907122302.GC5529@noname.redhat.com> References: <1441387117-27072-1-git-send-email-kwolf@redhat.com> <1441387117-27072-14-git-send-email-kwolf@redhat.com> <55E9F67D.9010909@redhat.com> <20150907120839.GB5529@noname.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3" Content-Disposition: inline In-Reply-To: <20150907120839.GB5529@noname.redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 13/13] qemu-iotests: More qcow2 reopen tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org --oC1+HKm2/end4ao3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 07.09.2015 um 14:08 hat Kevin Wolf geschrieben: > Am 04.09.2015 um 21:52 hat Max Reitz geschrieben: > > On 04.09.2015 19:18, Kevin Wolf wrote: > > > Signed-off-by: Kevin Wolf > > > --- > > > tests/qemu-iotests/137 | 143 +++++++++++++++++++++++++++++++++++= ++++++++++ > > > tests/qemu-iotests/137.out | 43 ++++++++++++++ > > > tests/qemu-iotests/group | 1 + > > > 3 files changed, 187 insertions(+) > > > create mode 100755 tests/qemu-iotests/137 > > > create mode 100644 tests/qemu-iotests/137.out > > >=20 > > > diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137 > > > new file mode 100755 > > > index 0000000..ad52f71 > > > --- /dev/null > > > +++ b/tests/qemu-iotests/137 > >=20 > >=20 > > [snip] > >=20 > > > +echo > > > +echo =3D=3D=3D Try setting some invalid values =3D=3D=3D > > > +echo > > > + > > > +$QEMU_IO \ > > > + -c "reopen -o lazy-refcounts=3D42" \ > > > + -c "reopen -o cache-size=3D1M,l2-cache-size=3D64k,refcount-cache= -size=3D64k" \ > > > + -c "reopen -o cache-size=3D1M,l2-cache-size=3D2M" \ > > > + -c "reopen -o cache-size=3D1M,refcount-cache-size=3D2M" \ > > > + -c "reopen -o l2-cache-size=3D256T" \ > > > + -c "reopen -o l2-cache-size=3D64G" \ > >=20 > > Testing this seems risky. The rest looks fine, but I'm not sure whether > > this is really needed so much that we should risk the test failing on > > some machines, especially in the future. >=20 > I think we should be testing the "too large, but not much too large" > case. A risk of false positives is better than a risk to break things > without noticing. I could make it something like 64T, though, that > should last a bit longer. The "much too large" case starts at 128T > (INT_MAX * s->cluster_size =3D=3D 2G * 64k). =2E..except that qcow2_cache_create() also allocates a Qcow2CachedTable array and that one is small enough in comparison that we'd end up again in the same range as before, where allocations might not fail right away, but fill up the swap. Fair enough, I'll remove the lines. Do you want a v3 on the list or can I fix it while merging? Kevin --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJV7YGmAAoJEH8JsnLIjy/WLs0QALPnu57i5fg05wU8rAS7t+fc Egg/0d7/m8s1Z6E3H0mV3qtQrN1UEVq67AWhhti9eyVc2gEMPJ/dZ9bLIAStmPaA 8UhvG5EK0X8MxTSqYOXs9tOdObO+MYCV8aEs/X0JzJ+ZcLU0Ziq1hQGk90QzZVKP XNgct7nFynF1hh05pawvmohK+3w67QtRLIDi7fir1AX+ykWW5/gqOwRMqmYGyTAB aSiG3HtGb66g9iPqiGVnPRUTMSkNf8pDkrHNmO08y/+KywJL/jwTvCgDbNJtQZWc 0GeoQlaHt5jrjLIuRRT6y2r2NU5/SqM0qsNkXO8KKSV+CKiUH8ZfcMH3d+mDXPX3 SheWumlt1nxo1lrYmYb2bR1FXZot+QU3etJZVDZveeOeM2dxa0FYt8LpWu+Mvc6G dRlDxFO5MWL1vW02SGUlALpOHDnlMR/+W0bvpcsdIPWXw542w2/msiL4mzi9Hl7o CrV682AlfLPc1YSpaXaL0h0BHNmQEVKlnXEDxtj5Mn2S0KB2XWzJJXhAkSqBkzpq tb9toGurFB3NmhVhsiaIv9jbykNtjEOVS+V/BEfbtfRkAVpi1Gb19ZqX0hlZGoYp Mp5A6GvfVFyoS9d8CpNKGg0fCHI5Ey8Q76HOcogwyKZLGfDxor2m4Gs8nngsz/DF UgQskRSLRwQLkpAWdfwy =naZ3 -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3--