From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYz6j-0005J9-0e for qemu-devel@nongnu.org; Mon, 07 Sep 2015 12:17:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYz6f-0005jw-Qh for qemu-devel@nongnu.org; Mon, 07 Sep 2015 12:17:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYz6f-0005jo-Lt for qemu-devel@nongnu.org; Mon, 07 Sep 2015 12:17:21 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 1EDA891C11 for ; Mon, 7 Sep 2015 16:17:21 +0000 (UTC) Date: Mon, 7 Sep 2015 17:17:16 +0100 From: "Daniel P. Berrange" Message-ID: <20150907161716.GV29882@redhat.com> References: <1441294768-8712-1-git-send-email-berrange@redhat.com> <1441294768-8712-30-git-send-email-berrange@redhat.com> <20150907160817.GH2337@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150907160817.GH2337@work-vm> Subject: Re: [Qemu-devel] [PATCH FYI 29/46] migration: remove use of qemu_bufopen from vmstate tests Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: Juan Quintela , qemu-devel@nongnu.org, Gerd Hoffmann , Amit Shah , Paolo Bonzini On Mon, Sep 07, 2015 at 05:08:17PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berrange@redhat.com) wrote: > > The test-vmstate.c file is the only remaining user of the > > qemu_bufopen function. Half of the test cases already use > > a temporary file, so convert the remaining cases to match > > As mentioned on irc; the buffered stuff is used by the postcopy > series and COLO. Yep, there's nothing in my series (yet) that really requires that we delete this QEMUFile impl. I was just trying to see if it was possible to get to a point where the /only/ QEMUFile impl was the QIOChannel one. I almost succeeded in that, the exception being the impl needed for writing internal QCow2 snapshots. I'll look at creating a memory buffer based QIOChannel, or alternatively just drop this patch, to avoid breaking COLO/postcopy. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|