From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZ3Or-0002uw-If for qemu-devel@nongnu.org; Mon, 07 Sep 2015 16:52:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZ3On-0006qx-IU for qemu-devel@nongnu.org; Mon, 07 Sep 2015 16:52:25 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:57603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZ3On-0006qn-BI for qemu-devel@nongnu.org; Mon, 07 Sep 2015 16:52:21 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Sep 2015 14:52:19 -0600 Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 5BDAC19D803E for ; Mon, 7 Sep 2015 14:43:12 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t87Kq9F050331848 for ; Mon, 7 Sep 2015 13:52:17 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t87KpiiC031401 for ; Mon, 7 Sep 2015 14:51:45 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <55EDF60B.8000007@redhat.com> References: <1440719744-24755-1-git-send-email-mdroth@linux.vnet.ibm.com> <1440719744-24755-4-git-send-email-mdroth@linux.vnet.ibm.com> <55ED6B7B.9060000@redhat.com> <20150907195547.10296.13210@loki> <20150907203723.10296.29727@loki> <55EDF60B.8000007@redhat.com> Message-ID: <20150907205123.10296.95829@loki> Date: Mon, 07 Sep 2015 15:51:23 -0500 Subject: Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, yhindin@redhat.com, leonid@daynix.com Quoting Paolo Bonzini (2015-09-07 15:39:39) > = > = > On 07/09/2015 22:37, Michael Roth wrote: > > This kinda does it, although it introduces a circular dependency warning > > on posix (since qemu-ga$(EXESUF) =3D=3D qemu-ga there, yet qemu-ga has > > a qemu-ga$(EXESUF) dependency. > > = > > Could be fixed by making a new 'qemu-guest-agent' do-the-right-thing ta= rget, > > but that means new build process for posix and w32 instead of just w32.= The > > alternative is to only define the 'qemu-ga' do-the-right-thing target f= or w32 > > (since posix already has such a target). That requires a Makefile ifdef= MINGW > > or somesuch though, which isn't ideal. I think the latter is worth the > > simplified build process (same as we currently do on posix, but with so= me > > extra config params) > = > Or just "ifneq ($(EXESUF),)". Thanks, that would work. Also noticed I forget the MSI dependency in previo= us patch. Will send a proper patch soon. > = > Paolo >=20