From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39102)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1ZZIZ3-0003Lb-JZ
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 09:04:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1ZZIYu-0002pp-Jc
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 09:03:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35097)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1ZZIYu-0002pa-Dr
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 09:03:48 -0400
Date: Tue, 8 Sep 2015 09:03:45 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20150908090345.6ee568e5@redhat.com>
In-Reply-To: <55EEB066.5040304@redhat.com>
References: <1441696197-22265-1-git-send-email-den@openvz.org>
	<1441696197-22265-3-git-send-email-den@openvz.org>
	<55EEB066.5040304@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code
	from monitor.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org, Pavel Butsykin <pbutsykin@virtuozzo.com>

On Tue, 8 Sep 2015 11:54:46 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> 
> 
> On 08/09/2015 09:09, Denis V. Lunev wrote:
> >  qemu-monitor-info.texi           | 151 +++++++
> 
> This should be added in patch 4, not now.
> 
> > +const MonitorDef *target_monitor_defs(void) __attribute__((weak));
> > +
> > +const MonitorDef *target_monitor_defs(void)
> > +{
> > +    return NULL;
> > +}
> 
> Weak symbols do not work on all platforms.  Luckily, making libqemustub
> a static library gets exactly the same result without the need for weak
> symbols: the definition from the QEMU object files will hide the stub.
> 
> You just need to remove __attribute__((weak)), and it should just work.
> 
> Otherwise, the patches look good to me.  Luiz, do you have time to post
> a pull request for v4, or do you want to pass HMP maintainership as well
> to someone else?

It would be great to pass it to someone else.