* [Qemu-devel] [PATCH] arm: xlnx-zynqmp: Fix up GIC region size
@ 2015-09-08 13:41 Nathan Rossi
2015-09-08 14:51 ` Edgar E. Iglesias
2015-09-11 15:32 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Rossi @ 2015-09-08 13:41 UTC (permalink / raw)
To: qemu-devel; +Cc: Edgar E . Iglesias, Nathan Rossi
The GIC in ZynqMP cover a 64K address space, however the actual
registers are decoded within a 4K address space and mirrored at the 4K
boundaries. This change fixes the defined size for these regions as it
was set to 0x4000/16K incorrectly.
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
---
include/hw/arm/xlnx-zynqmp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
index 6ccb57b..23b8453 100644
--- a/include/hw/arm/xlnx-zynqmp.h
+++ b/include/hw/arm/xlnx-zynqmp.h
@@ -44,7 +44,7 @@
* number of memory region aliases.
*/
-#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x4000
+#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x1000
#define XLNX_ZYNQMP_GIC_ALIASES (0x10000 / XLNX_ZYNQMP_GIC_REGION_SIZE - 1)
typedef struct XlnxZynqMPState {
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] arm: xlnx-zynqmp: Fix up GIC region size
2015-09-08 13:41 [Qemu-devel] [PATCH] arm: xlnx-zynqmp: Fix up GIC region size Nathan Rossi
@ 2015-09-08 14:51 ` Edgar E. Iglesias
2015-09-11 15:32 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Edgar E. Iglesias @ 2015-09-08 14:51 UTC (permalink / raw)
To: Nathan Rossi
Cc: Edgar E . Iglesias, crosthwaite.peter, alistair.francis,
qemu-devel, peter.maydell
On Tue, Sep 08, 2015 at 11:41:12PM +1000, Nathan Rossi wrote:
> The GIC in ZynqMP cover a 64K address space, however the actual
> registers are decoded within a 4K address space and mirrored at the 4K
> boundaries. This change fixes the defined size for these regions as it
> was set to 0x4000/16K incorrectly.
>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Adding Alistair, Crosthwaite and Maydell.
Thanks Nathan!
Edgar
> ---
> include/hw/arm/xlnx-zynqmp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
> index 6ccb57b..23b8453 100644
> --- a/include/hw/arm/xlnx-zynqmp.h
> +++ b/include/hw/arm/xlnx-zynqmp.h
> @@ -44,7 +44,7 @@
> * number of memory region aliases.
> */
>
> -#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x4000
> +#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x1000
> #define XLNX_ZYNQMP_GIC_ALIASES (0x10000 / XLNX_ZYNQMP_GIC_REGION_SIZE - 1)
>
> typedef struct XlnxZynqMPState {
> --
> 2.5.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] arm: xlnx-zynqmp: Fix up GIC region size
2015-09-08 13:41 [Qemu-devel] [PATCH] arm: xlnx-zynqmp: Fix up GIC region size Nathan Rossi
2015-09-08 14:51 ` Edgar E. Iglesias
@ 2015-09-11 15:32 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2015-09-11 15:32 UTC (permalink / raw)
To: Nathan Rossi; +Cc: Edgar E . Iglesias, QEMU Developers
On 8 September 2015 at 14:41, Nathan Rossi <nathan@nathanrossi.com> wrote:
> The GIC in ZynqMP cover a 64K address space, however the actual
> registers are decoded within a 4K address space and mirrored at the 4K
> boundaries. This change fixes the defined size for these regions as it
> was set to 0x4000/16K incorrectly.
>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
> include/hw/arm/xlnx-zynqmp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
> index 6ccb57b..23b8453 100644
> --- a/include/hw/arm/xlnx-zynqmp.h
> +++ b/include/hw/arm/xlnx-zynqmp.h
> @@ -44,7 +44,7 @@
> * number of memory region aliases.
> */
>
> -#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x4000
> +#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x1000
> #define XLNX_ZYNQMP_GIC_ALIASES (0x10000 / XLNX_ZYNQMP_GIC_REGION_SIZE - 1)
>
> typedef struct XlnxZynqMPState {
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-11 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-08 13:41 [Qemu-devel] [PATCH] arm: xlnx-zynqmp: Fix up GIC region size Nathan Rossi
2015-09-08 14:51 ` Edgar E. Iglesias
2015-09-11 15:32 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).