From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Michael S. Tsirkin" <mtsirkin@redhat.com>,
Huzaifa Sidhpurwala <huzaifas@redhat.com>,
P J P <pjp@fedoraproject.org>, Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, P J P <ppandit@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor
Date: Wed, 9 Sep 2015 10:10:10 +0100 [thread overview]
Message-ID: <20150909091010.GB9777@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1441383666-6590-1-git-send-email-stefanha@redhat.com>
On Fri, Sep 04, 2015 at 05:21:06PM +0100, Stefan Hajnoczi wrote:
> From: P J P <pjp@fedoraproject.org>
>
> While processing transmit descriptors, it could lead to an infinite
> loop if 'bytes' was to become zero; Add a check to avoid it.
>
> [The guest can force 'bytes' to 0 by setting the hdr_len and mss
> descriptor fields to 0.
> --Stefan]
>
> Signed-off-by: P J P <pjp@fedoraproject.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/net/e1000.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
next prev parent reply other threads:[~2015-09-09 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 16:21 [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor Stefan Hajnoczi
2015-09-07 9:04 ` Thomas Huth
2015-09-09 9:10 ` Stefan Hajnoczi
2015-09-09 9:10 ` Stefan Hajnoczi [this message]
2015-09-09 9:49 ` pjp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909091010.GB9777@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=huzaifas@redhat.com \
--cc=jasowang@redhat.com \
--cc=mtsirkin@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).