From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZbOP-0006qx-Td for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:10:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZbOP-0007rs-1k for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:10:13 -0400 Date: Wed, 9 Sep 2015 10:10:10 +0100 From: Stefan Hajnoczi Message-ID: <20150909091010.GB9777@stefanha-thinkpad.redhat.com> References: <1441383666-6590-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441383666-6590-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: "Michael S. Tsirkin" , Huzaifa Sidhpurwala , P J P , Jason Wang , qemu-devel@nongnu.org, P J P , qemu-stable@nongnu.org On Fri, Sep 04, 2015 at 05:21:06PM +0100, Stefan Hajnoczi wrote: > From: P J P > > While processing transmit descriptors, it could lead to an infinite > loop if 'bytes' was to become zero; Add a check to avoid it. > > [The guest can force 'bytes' to 0 by setting the hdr_len and mss > descriptor fields to 0. > --Stefan] > > Signed-off-by: P J P > Signed-off-by: Stefan Hajnoczi > --- > hw/net/e1000.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan