From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZbYT-0005Tx-St for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:20:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZbYM-0007nt-Sh for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:20:35 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:34195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZbYM-0007n3-Lg for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:20:30 -0400 Received: by wicfx3 with SMTP id fx3so149049353wic.1 for ; Wed, 09 Sep 2015 02:20:29 -0700 (PDT) Date: Wed, 9 Sep 2015 10:20:28 +0100 From: Stefan Hajnoczi Message-ID: <20150909092028.GE9777@stefanha-thinkpad.redhat.com> References: <1441619584-17992-1-git-send-email-pbonzini@redhat.com> <1441619584-17992-2-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441619584-17992-2-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/4] CODING_STYLE: update mixed declaration rules List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Markus Armbruster , qemu-devel@nongnu.org, Eduardo Habkost , Andreas Faerber On Mon, Sep 07, 2015 at 11:53:01AM +0200, Paolo Bonzini wrote: > Mixed declarations also do exist at the top of #ifdef blocks. > Reluctantly allow this particular usage and suggest an alternative. > > Signed-off-by: Paolo Bonzini > --- > CODING_STYLE | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi