From: Stefan Hajnoczi <stefanha@gmail.com>
To: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Cc: edgari@xilinx.com, peter.maydell@linaro.org, alistai@xilinx.com,
qemu-devel@nongnu.org, Sai Pavan Boddu <saipava@xilinx.com>,
crosthwaitepeter@gmail.com
Subject: Re: [Qemu-devel] [RFC V2 2/2] sdhci: Move sdhci.h to include/
Date: Wed, 9 Sep 2015 10:37:43 +0100 [thread overview]
Message-ID: <20150909093743.GI9777@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1441634319-23268-2-git-send-email-saipava@xilinx.com>
On Mon, Sep 07, 2015 at 07:28:39PM +0530, Sai Pavan Boddu wrote:
> Move sdhci.h to include/hw/sd/. Which makes easy creation of device
> using object_initialize.
>
> Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
> ---
> Changes for V2:
> Create new area in includes for sd. And move sdhci.h to same.
> ---
> hw/sd/sdhci.c | 2 +-
> {hw => include/hw}/sd/sdhci.h | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename {hw => include/hw}/sd/sdhci.h (100%)
Please keep hardware constants and any other device emulation internals
in hw/sd/. The header files in include/ should only contain that
"public" APIs that other parts of QEMU consume.
I think the declarations that need to be in include/ are:
1. typedef struct SDHCIState
2. TYPE_PCI_SDHCI and PCI_SDHCI()
3. TYPE_SYSBUS_SDHCI and SYSBUS_SDHCI()
The other declarations are internals that should be kept in hw/sd/.
This way there is a clear public API and internals (used by SD emulation
code).
next prev parent reply other threads:[~2015-09-09 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 13:58 [Qemu-devel] [RFC V2 1/2] hw/sd : move sd.h to include/hw/sd/ Sai Pavan Boddu
2015-09-07 13:58 ` [Qemu-devel] [RFC V2 2/2] sdhci: Move sdhci.h to include/ Sai Pavan Boddu
2015-09-09 9:37 ` Stefan Hajnoczi [this message]
2015-09-09 9:43 ` Sai Pavan Boddu
2015-09-09 15:04 ` [Qemu-devel] [RFC V2 1/2] hw/sd : move sd.h to include/hw/sd/ Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2015-09-08 5:52 Sai Pavan Boddu
2015-09-08 5:52 ` [Qemu-devel] [RFC V2 2/2] sdhci: Move sdhci.h to include/ Sai Pavan Boddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909093743.GI9777@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=alistai@xilinx.com \
--cc=crosthwaitepeter@gmail.com \
--cc=edgari@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=saipava@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).