From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZZbp7-0008JX-M3
	for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:37:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZZbp3-0001rc-Mi
	for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:37:49 -0400
Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:37114)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZZbp3-0001rP-Fm
	for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:37:45 -0400
Received: by wicfx3 with SMTP id fx3so14568951wic.0
	for <qemu-devel@nongnu.org>; Wed, 09 Sep 2015 02:37:45 -0700 (PDT)
Date: Wed, 9 Sep 2015 10:37:43 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150909093743.GI9777@stefanha-thinkpad.redhat.com>
References: <1441634319-23268-1-git-send-email-saipava@xilinx.com>
	<1441634319-23268-2-git-send-email-saipava@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1441634319-23268-2-git-send-email-saipava@xilinx.com>
Subject: Re: [Qemu-devel] [RFC V2 2/2] sdhci: Move sdhci.h to include/
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Cc: edgari@xilinx.com, peter.maydell@linaro.org, alistai@xilinx.com, qemu-devel@nongnu.org, Sai Pavan Boddu <saipava@xilinx.com>, crosthwaitepeter@gmail.com

On Mon, Sep 07, 2015 at 07:28:39PM +0530, Sai Pavan Boddu wrote:
> Move sdhci.h to include/hw/sd/. Which makes easy creation of device
> using object_initialize.
> 
> Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
> ---
> Changes for V2:
>    Create new area in includes for sd. And move sdhci.h to same.
> ---
>  hw/sd/sdhci.c                 | 2 +-
>  {hw => include/hw}/sd/sdhci.h | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename {hw => include/hw}/sd/sdhci.h (100%)

Please keep hardware constants and any other device emulation internals
in hw/sd/.  The header files in include/ should only contain that
"public" APIs that other parts of QEMU consume.

I think the declarations that need to be in include/ are:
1. typedef struct SDHCIState
2. TYPE_PCI_SDHCI and PCI_SDHCI()
3. TYPE_SYSBUS_SDHCI and SYSBUS_SDHCI()

The other declarations are internals that should be kept in hw/sd/.

This way there is a clear public API and internals (used by SD emulation
code).