From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40910)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1ZZldK-0004kp-3e
	for qemu-devel@nongnu.org; Wed, 09 Sep 2015 16:06:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1ZZldG-00060d-R3
	for qemu-devel@nongnu.org; Wed, 09 Sep 2015 16:06:18 -0400
Received: from e17.ny.us.ibm.com ([129.33.205.207]:33063)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1ZZldG-00060V-N0
	for qemu-devel@nongnu.org; Wed, 09 Sep 2015 16:06:14 -0400
Received: from /spool/local
	by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Wed, 9 Sep 2015 16:06:14 -0400
Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com
	[9.57.198.26])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id C5C1C38C804F
	for <qemu-devel@nongnu.org>; Wed,  9 Sep 2015 16:06:12 -0400 (EDT)
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	t89K6CEA56164578
	for <qemu-devel@nongnu.org>; Wed, 9 Sep 2015 20:06:12 GMT
Received: from d01av01.pok.ibm.com (localhost [127.0.0.1])
	by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	t89K6CAt018066
	for <qemu-devel@nongnu.org>; Wed, 9 Sep 2015 16:06:12 -0400
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <CAJ+F1CKVJyvwXbttDp89spj8pTZsQuqvC2Aw_cFFXmtGN4P+Wg@mail.gmail.com>
References: <1440672727-20231-1-git-send-email-marcandre.lureau@redhat.com>
	<1440672727-20231-2-git-send-email-marcandre.lureau@redhat.com>
	<CAJ+F1CKVJyvwXbttDp89spj8pTZsQuqvC2Aw_cFFXmtGN4P+Wg@mail.gmail.com>
Message-ID: <20150909173608.3885.65691@loki>
Date: Wed, 09 Sep 2015 12:36:08 -0500
Subject: Re: [Qemu-devel] [PATCH 2/2] tests: add a local test for guest agent
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@gmail.com>, QEMU <qemu-devel@nongnu.org>
Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>

Quoting Marc-Andr=C3=A9 Lureau (2015-08-27 06:36:43)
> On Thu, Aug 27, 2015 at 12:52 PM,  <marcandre.lureau@redhat.com> wrote:
> > +    success =3D success && status =3D=3D 0 && g_strcmp0(virt_what, vir=
t);
> =

> this is now:
> g_strcmp0(g_strstrip(virt_what), virt) =3D=3D 0

Just to be sure, is this the change you intended?

diff --git a/tests/test-qga.c b/tests/test-qga.c
index 1fb58ec..ca4bcb5 100644
--- a/tests/test-qga.c
+++ b/tests/test-qga.c
@@ -634,7 +634,8 @@ static gboolean running_in_virt(const gchar *virt)
     success =3D g_spawn_command_line_sync("virt-what", &virt_what, NULL,
                                         &status, NULL);
 =

-    success =3D success && status =3D=3D 0 && g_strcmp0(virt_what, virt);
+    success =3D success && status =3D=3D 0 &&
+        g_strcmp0(g_strstrip(virt_what), virt) =3D=3D 0;
 =

     g_free(virt_what);

> =

> -- =

> Marc-Andr=C3=A9 Lureau
>=20