From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za0Ym-0007l7-GB for qemu-devel@nongnu.org; Thu, 10 Sep 2015 08:02:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za0Yl-0000Bk-HW for qemu-devel@nongnu.org; Thu, 10 Sep 2015 08:02:36 -0400 Date: Thu, 10 Sep 2015 14:02:21 +0200 From: Kevin Wolf Message-ID: <20150910120221.GC4460@noname.redhat.com> References: <1441871594-21252-1-git-send-email-rgerganov@vmware.com> <20150910081557.GA27306@ad.nay.redhat.com> <55F143C6.5020401@vmware.com> <20150910085803.GB27306@ad.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150910085803.GB27306@ad.nay.redhat.com> Subject: Re: [Qemu-devel] [PATCH] vmdk: Fix next_cluster_sector for compressed write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-block@nongnu.org, Radoslav Gerganov , qemu-devel@nongnu.org Am 10.09.2015 um 10:58 hat Fam Zheng geschrieben: > On Thu, 09/10 11:48, Radoslav Gerganov wrote: > > On 10.09.2015 11:15, Fam Zheng wrote: > > > On Thu, 09/10 10:53, Radoslav Gerganov wrote: > > >> When the VMDK is streamOptimized (or compressed), the > > >> next_cluster_sector must not be incremented by a fixed number of > > >> sectors. Instead of this, it must be rounded up to the next consecutive > > >> sector. Fixing this results in much smaller compressed images. > > >> > > >> Signed-off-by: Radoslav Gerganov > > > > > > Is this patch enough to produce a valid streamOptimized image? Because I > > > remember there were reports on some other issues with footer or grain markers. > > > > > > Fam > > > > The VMDK spec says that each marker and its associated block must begin on > > sector boundary which is true before and after my patch. However, with my > > patch we don't put empty sectors when we achieve good compression for the > > current cluster but start the next cluster on the next consecutive sector. > > > > I have also verified that images produced with my patch can be booted in > > VMware Workstation. > > Thanks, the change looks good to me. > > Reviewed-by: Fam Zheng Thanks, applied to the block branch. Radoslav, for your next patch please remember to always keep qemu-devel CCed, even if you're sending the patch to a more specific mailing list. I'm adding it to this mail so that people who aren't subscribed to qemu-block have a chance to notice the patch. Kevin