From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZyE2-0006zp-Ju for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:33:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZyE1-0004RZ-Fs for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:33:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZyE1-0004RN-Bq for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:33:01 -0400 Date: Thu, 10 Sep 2015 12:32:58 +0300 From: "Michael S. Tsirkin" Message-ID: <20150910123113-mutt-send-email-mst@redhat.com> References: <1441816441-7730-1-git-send-email-pbonzini@redhat.com> <1441816441-7730-3-git-send-email-pbonzini@redhat.com> <20150910103319-mutt-send-email-mst@redhat.com> <55F14B34.5050906@redhat.com> <20150910122258-mutt-send-email-mst@redhat.com> <55F14D23.6090906@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55F14D23.6090906@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: cornelia.huck@de.ibm.com, den@openvz.org, qemu-devel@nongnu.org On Thu, Sep 10, 2015 at 11:28:03AM +0200, Paolo Bonzini wrote: > > > On 10/09/2015 11:25, Michael S. Tsirkin wrote: > > > It is needed because kvm headers include and you don't > > > want to pick the system version. > > > > I see. Makes sense. Then maybe don't bother with kvm.c either? > > Keeps it consistent ... > > kvm.c keeps it consistent between target-i386/kvm.c and > target-i386/cpu.h (which will include standard-headers/asm-x86/hyperv.h > in Denis's patch). > > Paolo Yes but kvm_para.h uses asm/hyperv.h MAybe do the same everywhere? Seems marginally prettier, but you decide, I'm not interested in pushing this point. -- MST