From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44982)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZZyMS-0000nC-SW
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:41:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZZyMP-00011E-MA
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:41:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50422)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZZyMP-0000zy-Ha
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 05:41:41 -0400
Date: Thu, 10 Sep 2015 12:41:38 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150910124129-mutt-send-email-mst@redhat.com>
References: <1441877978-31156-1-git-send-email-pbonzini@redhat.com>
	<1441877978-31156-2-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1441877978-31156-2-git-send-email-pbonzini@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 1/4] pci: remove Link Training error
 from AER error list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: cornelia.huck@de.ibm.com, qemu-devel@nongnu.org

On Thu, Sep 10, 2015 at 11:39:35AM +0200, Paolo Bonzini wrote:
> The spec says:
>=20
> Undefined =E2=80=93 The value read from this bit is
> undefined. In previous versions of this
> specification, this bit was used to indicate a Link
> Training Error. System software must ignore the
> value read from this bit. System software is
> permitted to write any value to this bit.
>=20
> Do not allow injecting it.
>=20
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci/pcie_aer.c | 4 ----
>  1 file changed, 4 deletions(-)
>=20
> diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
> index f1847ac..46e0ad8 100644
> --- a/hw/pci/pcie_aer.c
> +++ b/hw/pci/pcie_aer.c
> @@ -827,10 +827,6 @@ typedef struct PCIEAERErrorName {
>   */
>  static const struct PCIEAERErrorName pcie_aer_error_list[] =3D {
>      {
> -        .name =3D "TRAIN",
> -        .val =3D PCI_ERR_UNC_TRAIN,
> -        .correctable =3D false,
> -    }, {
>          .name =3D "DLP",
>          .val =3D PCI_ERR_UNC_DLP,
>          .correctable =3D false,
> --=20
> 2.4.3
>=20