From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: bharata@linux.vnet.ibm.com, Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] pc: memhotplug: fix incorrectly set reserved-memory-end
Date: Thu, 10 Sep 2015 13:42:31 +0300 [thread overview]
Message-ID: <20150910134121-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20150910115907.2112265e@nial.brq.redhat.com>
On Thu, Sep 10, 2015 at 11:59:07AM +0200, Igor Mammedov wrote:
> On Wed, 9 Sep 2015 17:03:56 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> > On Mon, Sep 07, 2015 at 01:55:31PM +0200, Igor Mammedov wrote:
> > > reserved-memory-end tells firmware address from which
> > > it could start treating memory as PCI address space
> > > and map PCI BARs after it to avoid collisions with
> > > RAM.
> > > Currently it is incorrectly pointing to address where
> > > hotplugged memory range starts which could redirect
> > > hotplugged RAM accesses to PCI BARs when firmware
> > > maps them over RAM or viceverse.
> > > Fix this by pointing reserved-memory-end to the end
> > > of memory hotplug area.
> > >
> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> >
> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> >
> > But I would like to see this squashed into patch 2/2 (or the rebased
> > version of patch 2/2) to keep bisectability.
>
> Eduardo, thanks for review.
> It's ok squash 2/2, could you handle it and take it through your tree?
I merged them separately already:
I'm not too concerned about breaking cross version migration
being slightly racy when doing bisect.
--
MST
next prev parent reply other threads:[~2015-09-10 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 11:55 [Qemu-devel] [PATCH 0/2] pc: fix 64-bit PCI window clashing with memory hotplug region Igor Mammedov
2015-09-07 11:55 ` [Qemu-devel] [PATCH 1/2] pc: memhotplug: fix incorrectly set reserved-memory-end Igor Mammedov
2015-09-09 20:03 ` Eduardo Habkost
2015-09-10 9:59 ` Igor Mammedov
2015-09-10 10:42 ` Michael S. Tsirkin [this message]
2015-09-07 11:55 ` [Qemu-devel] [PATCH 2/2] pc: memhotplug: keep reserved-memory-end broken on 2.4 and earlier machines Igor Mammedov
2015-09-09 20:14 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910134121-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).