From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39546)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZZzN1-0003ba-V8
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 06:46:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZZzMx-0001xB-4J
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 06:46:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44582)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZZzMw-0001x1-VC
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 06:46:19 -0400
Date: Thu, 10 Sep 2015 13:46:14 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150910134514-mutt-send-email-mst@redhat.com>
References: <alpine.DEB.2.02.1509081818590.2672@kaball.uk.xensource.com>
	<CAFEAcA80p5jaGYstmXYH204OExVUm2Mn=qfxC3FeibzPNDi7Tw@mail.gmail.com>
	<alpine.DEB.2.02.1509091248460.2672@kaball.uk.xensource.com>
	<alpine.DEB.2.02.1509091706120.2672@kaball.uk.xensource.com>
	<55F0DB30.6070607@intel.com>
	<CAFEAcA9RM0Q0ZrhgZxYqRdYb+GTsd7QyZtNJGKqxOYse8vShfA@mail.gmail.com>
	<55F14E20.6070805@intel.com>
	<alpine.DEB.2.02.1509101041540.2672@kaball.uk.xensource.com>
	<alpine.DEB.2.02.1509101122570.2672@kaball.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1509101122570.2672@kaball.uk.xensource.com>
Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Chen, Tiejun" <tiejun.chen@intel.com>, "xen-devel@lists.xensource.com Devel" <xen-devel@lists.xensource.com>, QEMU Developers <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote:
> CC Michael
> 
> On Thu, 10 Sep 2015, Stefano Stabellini wrote:
> > On Thu, 10 Sep 2015, Chen, Tiejun wrote:
> > > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH
> > > > was set by configure. That won't be the case on OSX or Windows, where
> > > > the Xen headers don't exist.
> > > > 
> > > 
> > > Okay. This actually shouldn't be enabled on Windows so what about this?
> > 
> > I think it would be nicer to replace the pread than introducing ifdefs.
> 
> Something like:
> 
> ---
> Replace pread with read to avoid build breakages on Windows
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

I'd prefer a wrapper that does the right thing.
No sense in doubling the # of system calls for everyone.

> 
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 58a33fb..9a40429 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -774,8 +774,11 @@ static int host_pci_config_read(int pos, int len, uint32_t val)
>          return -ENODEV;
>      }
>  
> +    if (lseek(config_fd, pos, SEEK_SET) != pos) {
> +        return -errno;
> +    }
>      do {
> -        rc = pread(config_fd, (uint8_t *)&val, len, pos);
> +        rc = read(config_fd, (uint8_t *)&val, len);
>      } while (rc < 0 && (errno == EINTR || errno == EAGAIN));
>      if (rc != len) {
>          return -errno;