From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za0ja-0006Z8-Or for qemu-devel@nongnu.org; Thu, 10 Sep 2015 08:13:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za0jX-0006mH-Kf for qemu-devel@nongnu.org; Thu, 10 Sep 2015 08:13:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za0jX-0006mD-FE for qemu-devel@nongnu.org; Thu, 10 Sep 2015 08:13:43 -0400 Date: Thu, 10 Sep 2015 15:13:40 +0300 From: "Michael S. Tsirkin" Message-ID: <20150910151326-mutt-send-email-mst@redhat.com> References: <55F0DB30.6070607@intel.com> <55F14E20.6070805@intel.com> <20150910134514-mutt-send-email-mst@redhat.com> <20150910150006-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: "Chen, Tiejun" , "xen-devel@lists.xensource.com Devel" , QEMU Developers , Peter Maydell On Thu, Sep 10, 2015 at 01:00:35PM +0100, Stefano Stabellini wrote: > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > On Thu, Sep 10, 2015 at 12:26:21PM +0100, Stefano Stabellini wrote: > > > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > > > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > > > > > CC Michael > > > > > > > > > > On Thu, 10 Sep 2015, Stefano Stabellini wrote: > > > > > > On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > > > > > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH > > > > > > > > was set by configure. That won't be the case on OSX or Windows, where > > > > > > > > the Xen headers don't exist. > > > > > > > > > > > > > > > > > > > > > > Okay. This actually shouldn't be enabled on Windows so what about this? > > > > > > > > > > > > I think it would be nicer to replace the pread than introducing ifdefs. > > > > > > > > > > Something like: > > > > > > > > > > --- > > > > > Replace pread with read to avoid build breakages on Windows > > > > > > > > > > Signed-off-by: Stefano Stabellini > > > > > > > > I'd prefer a wrapper that does the right thing. > > > > No sense in doubling the # of system calls for everyone. > > > > > > If this was done on an hot path I would agree with you, but it is just > > > one call at initialization time (igd_pt_i440fx_initfn). > > > > I missed this fact. OK then. > > Thanks! I'll fold it the offending patch > (http://marc.info/?l=qemu-devel&m=144174596628052&w=2) and resend. > Reviewed-by: Michael S. Tsirkin > > > > > diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c > > > > > index 58a33fb..9a40429 100644 > > > > > --- a/hw/pci-host/piix.c > > > > > +++ b/hw/pci-host/piix.c > > > > > @@ -774,8 +774,11 @@ static int host_pci_config_read(int pos, int len, uint32_t val) > > > > > return -ENODEV; > > > > > } > > > > > > > > > > + if (lseek(config_fd, pos, SEEK_SET) != pos) { > > > > > + return -errno; > > > > > + } > > > > > do { > > > > > - rc = pread(config_fd, (uint8_t *)&val, len, pos); > > > > > + rc = read(config_fd, (uint8_t *)&val, len); > > > > > } while (rc < 0 && (errno == EINTR || errno == EAGAIN)); > > > > > if (rc != len) { > > > > > return -errno; > > > > > >