From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaCbI-0006UP-1z for qemu-devel@nongnu.org; Thu, 10 Sep 2015 20:54:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaCbF-0006GW-6X for qemu-devel@nongnu.org; Thu, 10 Sep 2015 20:53:59 -0400 Date: Fri, 11 Sep 2015 10:39:49 +1000 From: David Gibson Message-ID: <20150911003949.GE11781@voom> References: <1441919463-24963-1-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Oiv9uiLrevHtW1RS" Content-Disposition: inline In-Reply-To: <1441919463-24963-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 1/2] spapr_drc: use RTAS return codes for methods called by RTAS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Bharata B Rao --Oiv9uiLrevHtW1RS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 10, 2015 at 04:11:02PM -0500, Michael Roth wrote: > Certain methods in sPAPRDRConnector objects are only ever called by > RTAS and in many cases are responsible for the logic that determines > the RTAS return codes. >=20 > Rather than having a level of indirection requiring RTAS code to > re-interpret return values from such methods to determine the > appropriate return code, just pass them through directly. >=20 > This requires changing method return types to uint32_t to match the > type of values currently passed to RTAS helpers. >=20 > In the case of read accesses like drc->entity_sense() where we weren't > previously reporting any errors, just the read value, we modify the > function to return RTAS return code, and pass the read value back via > reference. >=20 > Suggested-by: Bharata B Rao > Suggested-by: David Gibson > Cc: qemu-ppc@nongnu.org > Cc: David Gibson > Cc: Bharata B Rao > Signed-off-by: Michael Roth Series applied to spapr-dev, thanks. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Oiv9uiLrevHtW1RS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV8iLVAAoJEGw4ysog2bOSVxkP/1z4VicdPFbBPbiDkKWShV8l IXDyXCD0O+8lPK04gVsz288DUQzt0WygceXDBf+sFyveFiJUOoitEGZ21jaQEWu0 SGg3k/uKqutCpO/n9kuS+2/OpCCJj4doUrA8kIEEPKoPU4BgSDELBv3E/0L20OEB SOpZFJEXMt0mGEbCPwrWrdGarRfmPDPK20/iWZn7DR2Fwpc7+1k+mKaRBvGpblC2 tQF+1Pc5uUPx4y7RkJ8Ak5FhbeyDvk/Lj8/32j2FxGAz0YVPCbA3rbotWGfFfNKC 0ujQVUsy24lBd4uJB12rXsb06E0k0/wtv3Ub1FfofeCEgk82Tsr4d4JwofFVK+DD HsFn8Y41qzeSo97r2JuDmeT9YAAUSuZGMJTyChQGg2FLNMvPFDGBJ0lmfd/ewcq2 lH0xBcO2dbg5XYaF0x8kMOKJFed/60qYRr3CNZlQg2lw+mn67OAy0BLn3w/o18KE U/lx4UKPBXDH3S0zvVA6H1TQtvIN7BKu1s09NgJreXLN/RmRqcuEHpFttSOBi44l M0FjFcA5/4VdJDplnraJMgUb8322awm6ZeFodnXPTSiJhbS/tGbOeQ7dngsi0PFI IVNVDD6IQawd88EAnVMy9k5RCZV+ShZF2ber+JxLButYtJRCPpOqqQBZ90M4ZfGo Q5ZHdDDrRCW2R7YF5th5 =yIHb -----END PGP SIGNATURE----- --Oiv9uiLrevHtW1RS--