From: Fam Zheng <famz@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/1] atapi: abort transfers with 0 byte limits
Date: Fri, 11 Sep 2015 11:11:41 +0800 [thread overview]
Message-ID: <20150911031141.GA2592@ad.nay.redhat.com> (raw)
In-Reply-To: <1441927256-24625-2-git-send-email-jsnow@redhat.com>
On Thu, 09/10 19:20, John Snow wrote:
>
> + /* Nondata commands permit the byte_count_limit to be 0.
> + * If this is a data-transferring PIO command and BCL is 0,
> + * we abort at the /ATA/ level, not the ATAPI level.
> + * See ATA8 ACS3 section 7.17.6.49 and 7.21.5 */
> + if (!(atapi_cmd_table[s->io_buffer[0]].flags & NONDATA)) {
> + /* TODO: Check IDENTIFY data word 125 for default BCL (currently 0) */
> + uint16_t byte_count_limit = s->lcyl | (s->hcyl << 8);
> + if !(byte_count_limit || s->atapi_dma) {
!( ?
Fam
next prev parent reply other threads:[~2015-09-11 3:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 23:20 [Qemu-devel] [PATCH v2 0/1] atapi: abort transfers with 0 byte limits John Snow
2015-09-10 23:20 ` [Qemu-devel] [PATCH v2 1/1] " John Snow
2015-09-11 3:11 ` Fam Zheng [this message]
2015-09-14 16:03 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911031141.GA2592@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).