Re: [Qemu-devel] [PATCH 33/34] linux-user: Support for restarting system calls for CRIS targets

["Edgar E. Iglesias" <edgar.iglesias@xilinx.com>]

On Fri, Sep 11, 2015 at 03:20:31PM +0100, Peter Maydell wrote:
> On 11 September 2015 at 15:18, Edgar E. Iglesias
> <edgar.iglesias@xilinx.com> wrote:
> > On Thu, Sep 10, 2015 at 08:12:21PM +0100, Peter Maydell wrote:
> >> On 6 September 2015 at 00:57, Timothy E Baldwin
> >> <T.E.Baldwin99@members.leeds.ac.uk> wrote:
> >> > Signed-off-by: Timothy Edward Baldwin <T.E.Baldwin99@members.leeds.ac.uk>
> >> > ---
> >> >
> >> > WARNING - NOT TESTED
> >> >
> >> >  linux-user/cris/syscall.h | 2 ++
> >> >  linux-user/main.c         | 6 +++++-
> >> >  linux-user/signal.c       | 2 +-
> >> >  3 files changed, 8 insertions(+), 2 deletions(-)
> 
> 
> >> Looks OK, but this one I'm not sure enough about the CRIS instruction
> >> set and the surrounding code doesn't clarify. Edgar -- is the CRIS
> >> instruction for "take linux system call" always exactly 2 bytes long?
> >>
> >
> > Yes, those are always 2 bytes.
> 
> Cool. In that case
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>

Thanks, me too:

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>