From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbPhZ-0008Ox-0L for qemu-devel@nongnu.org; Mon, 14 Sep 2015 05:05:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbPhV-0005QH-Qw for qemu-devel@nongnu.org; Mon, 14 Sep 2015 05:05:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbPhV-0005QD-LY for qemu-devel@nongnu.org; Mon, 14 Sep 2015 05:05:25 -0400 Date: Mon, 14 Sep 2015 10:05:21 +0100 From: "Daniel P. Berrange" Message-ID: <20150914090521.GD7611@redhat.com> References: <1441783481-17698-1-git-send-email-yanghy@cn.fujitsu.com> <55F65685.7080504@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55F65685.7080504@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v10 00/10] Add a netfilter object and netbuffer filter Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com On Mon, Sep 14, 2015 at 01:09:25PM +0800, Yang Hongyang wrote: > Hi Stefan,Jason, > > I've convert this series to base on QOM, and introducing NetQueue apis > instead of using Netqueue internals as Stefan suggested. Could you please take a > look at it? I won't look at the actual net filtering stuff since that's not my area of expertize. I looked at the QOM related patches and that stuff all looks good to me, with a few small nitpicks. > Most of the details have been reviewed by Jason, and the whole filter logic > isn't changed. > One missing feature compared to previous versions is the multiqueue support, > however, I've already implemented it, before sending it out, I need to get as > many review comments as possible on this series, and addressing it, in order to > reduce the iter round...And multiqueue support can be sent later as a seperate > series if the base can go in first. If there has to be another few rounds, I > will include multiqueue patches. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|