From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35642)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1ZbNtk-0003qA-Me
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 03:09:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1ZbNtg-0005p1-Lk
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 03:09:56 -0400
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:50317)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1ZbNtg-0005o2-Ck
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 03:09:52 -0400
Received: from /spool/local
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Mon, 14 Sep 2015 08:09:49 +0100
Received: from b06cxnps4076.portsmouth.uk.ibm.com
	(d06relay13.portsmouth.uk.ibm.com [9.149.109.198])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3DF20219005C
	for <qemu-devel@nongnu.org>; Mon, 14 Sep 2015 08:09:19 +0100 (BST)
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t8E79lRp34865202
	for <qemu-devel@nongnu.org>; Mon, 14 Sep 2015 07:09:47 GMT
Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t8E79lmu025388
	for <qemu-devel@nongnu.org>; Mon, 14 Sep 2015 01:09:47 -0600
Date: Mon, 14 Sep 2015 09:09:44 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20150914090944.0eee5e23.cornelia.huck@de.ibm.com>
In-Reply-To: <7d0523c8a62a3677ea2e3e125cea9233a97650a7.1441667360.git.crosthwaite.peter@gmail.com>
References: <cover.1441667360.git.crosthwaite.peter@gmail.com>
	<7d0523c8a62a3677ea2e3e125cea9233a97650a7.1441667360.git.crosthwaite.peter@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v1 02/25] s390x: virtio-ccw: Remove
 un-needed if guard
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com

On Thu, 10 Sep 2015 22:33:12 -0700
Peter Crosthwaite <crosthwaitepeter@gmail.com> wrote:

> error_propagate is already NULL safe. Remove these un-needed if
> guards.
> 
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> 
>  hw/s390x/virtio-ccw.c | 28 +++++++---------------------
>  1 file changed, 7 insertions(+), 21 deletions(-)

Shorter code is good :)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>