From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbWds-0003w1-K8 for qemu-devel@nongnu.org; Mon, 14 Sep 2015 12:30:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbWdr-0000de-LP for qemu-devel@nongnu.org; Mon, 14 Sep 2015 12:30:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbWdr-0000bs-GW for qemu-devel@nongnu.org; Mon, 14 Sep 2015 12:30:07 -0400 Date: Mon, 14 Sep 2015 18:30:01 +0200 From: Andrew Jones Message-ID: <20150914163001.GC4652@hawk.localdomain> References: <1442156793-30708-1-git-send-email-leif.lindholm@linaro.org> <1442156793-30708-2-git-send-email-leif.lindholm@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442156793-30708-2-git-send-email-leif.lindholm@linaro.org> Subject: Re: [Qemu-devel] [PATCH v2 1/2] ACPI: Add definitions for the DBG2 table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leif Lindholm Cc: peter.maydell@linaro.org, imammedo@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, shannon.zhao@linaro.org On Sun, Sep 13, 2015 at 04:06:32PM +0100, Leif Lindholm wrote: > The DBG2 table can be considered a "companion" to SPCR - it points out > debug consoles available in the system. > > Also update SPCR comments to reflect DBG2 is now described in this file, > and update the supported SPCR specification revision (no functional > change). > > Signed-off-by: Leif Lindholm > --- > include/hw/acpi/acpi-defs.h | 35 +++++++++++++++++++++++++++++++++-- > 1 file changed, 33 insertions(+), 2 deletions(-) > > diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h > index 2b431e6..a7bd984 100644 > --- a/include/hw/acpi/acpi-defs.h > +++ b/include/hw/acpi/acpi-defs.h > @@ -197,10 +197,41 @@ enum { > }; > > /* > - * Serial Port Console Redirection Table (SPCR), Rev. 1.02 > + * Debug Port Table 2 (DBG2) > * > * For .interface_type see Debug Port Table 2 (DBG2) serial port > - * subtypes in Table 3, Rev. May 22, 2012 > + * subtypes in Table 3, Rev. Aug 10, 2015 > + * > + */ > +struct AcpiDebugPort2Header { > + ACPI_TABLE_HEADER_DEF > + uint32_t devices_offset; > + uint32_t devices_count; > +} QEMU_PACKED; > +typedef struct AcpiDebugPort2Header > + AcpiDebugPort2Header; typedef line could be all on one line > + > +struct AcpiDebugPort2Device { > + uint8_t revision; > + uint16_t length; > + uint8_t address_count; > + uint16_t namepath_length; > + uint16_t namepath_offset; > + uint16_t oem_data_length; > + uint16_t oem_data_offset; > + uint16_t port_type; > + uint16_t port_subtype; > + uint8_t reserved1[2]; > + uint16_t base_address_offset; > + uint16_t address_size_offset; > +} QEMU_PACKED; > +typedef struct AcpiDebugPort2Device > + AcpiDebugPort2Device; also could be on one line > + > +/* > + * Serial Port Console Redirection Table (SPCR), Rev. 1.03 > + * > + * .interface_type format same as for DBG2. > */ > struct AcpiSerialPortConsoleRedirection { > ACPI_TABLE_HEADER_DEF > -- > 2.1.4 > > Otherwise Reviewed-by: Andrew Jones