From: Fam Zheng <famz@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
vsementsov@parallels.com, stefanha@redhat.com,
John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function
Date: Tue, 15 Sep 2015 13:00:21 +0800 [thread overview]
Message-ID: <20150915050021.GG14016@ad.nay.redhat.com> (raw)
In-Reply-To: <55F32CE9.9060201@redhat.com>
On Fri, 09/11 13:35, Eric Blake wrote:
> On 09/07/2015 01:34 AM, Fam Zheng wrote:
> > This will be reused by the coming new transactional completion code.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > Reviewed-by: John Snow <jsnow@redhat.com>
> > ---
> > block/backup.c | 26 ++++++++++++++++----------
> > 1 file changed, 16 insertions(+), 10 deletions(-)
> >
> > diff --git a/block/backup.c b/block/backup.c
> > index 965654d..9776d9c 100644
> > --- a/block/backup.c
> > +++ b/block/backup.c
> > @@ -210,6 +210,21 @@ static void backup_iostatus_reset(BlockJob *job)
> >
> > bdrv_iostatus_reset(s->target);
> > }
> > +static void backup_cleanup_sync_bitmap(BackupBlockJob *job, int ret)
>
> Blank lines between functions?
>
OK, will add one!
Fam
next prev parent reply other threads:[~2015-09-15 5:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 7:34 [Qemu-devel] [PATCH v5 00/14] block: incremental backup transactions using BlockJobTxn Fam Zheng
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 01/14] qapi: Add transaction support to block-dirty-bitmap operations Fam Zheng
2015-09-11 18:56 ` Eric Blake
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 02/14] iotests: add transactional incremental backup test Fam Zheng
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 03/14] block: rename BlkTransactionState and BdrvActionOps Fam Zheng
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function Fam Zheng
2015-09-11 18:26 ` Max Reitz
2015-09-11 19:35 ` Eric Blake
2015-09-15 5:00 ` Fam Zheng [this message]
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 05/14] blockjob: Introduce reference count Fam Zheng
2015-09-11 18:26 ` Max Reitz
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 06/14] blockjob: Add .commit and .abort block job actions Fam Zheng
2015-09-11 18:27 ` Max Reitz
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 07/14] blockjob: Add "completed" and "ret" in BlockJob Fam Zheng
2015-09-11 18:27 ` Max Reitz
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 08/14] blockjob: Simplify block_job_finish_sync Fam Zheng
2015-09-11 18:28 ` Max Reitz
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 09/14] block: Add block job transactions Fam Zheng
2015-09-11 18:34 ` Max Reitz
2015-09-11 18:52 ` Max Reitz
2015-09-15 5:02 ` Fam Zheng
2015-09-18 11:09 ` Max Reitz
2015-09-18 11:15 ` Max Reitz
2015-09-11 19:58 ` Eric Blake
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 10/14] blockdev: make BlockJobTxn available to qmp 'transaction' Fam Zheng
2015-09-11 18:38 ` Max Reitz
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 11/14] block/backup: support block job transactions Fam Zheng
2015-09-11 18:50 ` Max Reitz
2015-09-11 21:26 ` Eric Blake
2015-09-15 5:08 ` Fam Zheng
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 12/14] iotests: 124 - transactional failure test Fam Zheng
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 13/14] qmp-commands.hx: Update the supported 'transaction' operations Fam Zheng
2015-09-07 7:34 ` [Qemu-devel] [PATCH v5 14/14] tests: add BlockJobTxn unit test Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915050021.GG14016@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).