From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbiM3-0004ra-Cw for qemu-devel@nongnu.org; Tue, 15 Sep 2015 01:00:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbiLy-0003bp-Dd for qemu-devel@nongnu.org; Tue, 15 Sep 2015 01:00:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbiLy-0003bQ-8I for qemu-devel@nongnu.org; Tue, 15 Sep 2015 01:00:26 -0400 Date: Tue, 15 Sep 2015 13:00:21 +0800 From: Fam Zheng Message-ID: <20150915050021.GG14016@ad.nay.redhat.com> References: <1441611277-24596-1-git-send-email-famz@redhat.com> <1441611277-24596-5-git-send-email-famz@redhat.com> <55F32CE9.9060201@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55F32CE9.9060201@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Jeff Cody , qemu-devel@nongnu.org, Max Reitz , vsementsov@parallels.com, stefanha@redhat.com, John Snow On Fri, 09/11 13:35, Eric Blake wrote: > On 09/07/2015 01:34 AM, Fam Zheng wrote: > > This will be reused by the coming new transactional completion code. > > > > Signed-off-by: Fam Zheng > > Reviewed-by: John Snow > > --- > > block/backup.c | 26 ++++++++++++++++---------- > > 1 file changed, 16 insertions(+), 10 deletions(-) > > > > diff --git a/block/backup.c b/block/backup.c > > index 965654d..9776d9c 100644 > > --- a/block/backup.c > > +++ b/block/backup.c > > @@ -210,6 +210,21 @@ static void backup_iostatus_reset(BlockJob *job) > > > > bdrv_iostatus_reset(s->target); > > } > > +static void backup_cleanup_sync_bitmap(BackupBlockJob *job, int ret) > > Blank lines between functions? > OK, will add one! Fam