Re: [Qemu-devel] [PATCH v7 09/26] qapi: De-duplicate enum code generation

["Daniel P. Berrange" <berrange@redhat.com>]

On Mon, Sep 14, 2015 at 07:57:40PM +0200, Markus Armbruster wrote:
> Duplicated in commit 21cd70d.  Yes, we can't import qapi-types, but
> that's no excuse.  Move the helpers from qapi-types.py to qapi.py, and
> replace the duplicates in qapi-event.py.
> 
> The generated event enumeration type's lookup table becomes
> const-correct (see commit 2e4450f), and uses explicit indexes instead
> of relying on order (see commit 912ae9c).
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  docs/qapi-code-gen.txt |  9 ++++---
>  scripts/qapi-event.py  | 67 +++-----------------------------------------------
>  scripts/qapi-types.py  | 55 -----------------------------------------
>  scripts/qapi.py        | 55 +++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 64 insertions(+), 122 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|